Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
scazan
force-pushed
the
onboarding-es-translations-typed-i18n
branch
from
34f1e65 to
9715431
Compare
nourmalaeb
approved these changes
Feb 26, 2026
Comment on lines
+43
to
+50
| <span className="text-neutral-gray4"> | ||
| {t.rich('Results for <highlight>{query}</highlight>', { | ||
| query: query, | ||
| highlight: (chunks: React.ReactNode) => ( | ||
| <span className="text-neutral-black">{chunks}</span> | ||
| ), | ||
| })} | ||
| </span> |
Collaborator
There was a problem hiding this comment.
Nice, didn't know we could do this 👍
scazan
force-pushed
the
onboarding-es-translations-typed-i18n
branch
from
9715431 to
691c645
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that all translation keys are properly typed against the dictionary. It makes sure that we never have translations keys that don't exist in the dictionary with translations.
Typecheck now flags these situations and your IDE should also be showing it as an error.
Example with a bad translation key