chore(deps): update gql to v4 #598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's worth mentioning that the documentation suggests[^1] setting `variable_values` directly on the (in our case, global) query object, and doesn't really talk about race conditions, but I would assume they can happen, especially in async code. It might be fine if you call `gql.gql(<str>)` every time, which might be what the documentation suggests, but that seems like a performance nightmare. Therefore, we just construct a new `GraphQLRequest` from the existing globals, which automatically copies over the parsed `Document` node, so it should have little to no overhead. [^1]: https://gql.readthedocs.io/en/latest/usage/variables.html
transports now log with `DEBUG` instead of `INFO`, so we can go back up to `INFO` without getting too spammy.
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: monty/log.py
|
onerandomusername
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://github.com/graphql-python/gql/releases/tag/v4.0.0.
Regarding specific changes,
all the information is on the taskall the info is in the commit messages.