Allow ContentBase derivatives to control how their pages are indexed by Watson#184
Merged
daniel-clayton merged 5 commits intodevelopfrom Oct 25, 2019
Merged
Conversation
added 5 commits
October 16, 2019 17:55
…xed with in Watson searches.
… they are searched by Watson.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
PageSearchAdapterwill examine allCharFieldandTextFieldderivatives on the page's content model to work out what should be indexed by the internal search engine. This works well, when pages are largely built out of those field types.However, it doesn't allow searching deeper into other types of field, such as
ForeignKeys. The obvious use case is our standard sections app, where all or nearly all of the page's content is built out of other models.This changes the behaviour to add
get_searchable_texttoContentBase, which is called byget_contentonPageSearchAdapter. This will allow derivatives to override what text is seen byget_content.As a bonus, this also improves the tests - it does not appear to have been testing the text field search indexing at all, because the test model had no text fields on it.