Merged
Conversation
PR SummaryRefactored token management system to support verified tokens and improved token display functionality. Removed legacy balance and coin rate managers in favor of a new unified FungibleTokenListManager. Added support for both EVM and Flow tokens with enhanced token metadata and verification status. Changes
autogenerated by presubmit.ai |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- 5684f65: feat: verified token
Files Processed (30)
- app/src/main/AndroidManifest.xml (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/cache/DisplayTokenCacheManager.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/firebase/config/FirebaseConfig.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/manager/LaunchManager.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/account/BalanceManager.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/manager/coin/CoinRateManager.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/manager/coin/CustomTokenManager.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/coin/FlowCoinListManager.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/manager/evm/EVMWalletManager.kt (5 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/evm/Utils.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/flowjvm/CadenceExecutor.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/token/FungibleTokenListManager.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/manager/token/model/FungibleToken.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/network/ApiService.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/network/UserRegisterUtils.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/network/model/EVMTokenListResponse.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/network/model/FlowTokenListResponse.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/Utils.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/dialog/processing/send/SendProcessingViewModel.kt (5 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/dialog/processing/send/presenter/SendProcessingPresenter.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/inbox/InboxViewModel.kt (5 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/inbox/presenter/InboxTokenItemPresenter.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/main/Utils.kt (5 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/profile/subpage/currency/CurrencyViewModel.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/profile/subpage/currency/model/Currency.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/profile/subpage/wallet/childaccountdetail/ChildAccountDetailViewModel.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/scan/Utils.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/send/transaction/TransactionSendActivity.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/send/transaction/subpage/amount/SendAmountActivity.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/send/transaction/subpage/amount/SendAmountViewModel.kt (3 hunks)
Actionable Comments (1)
-
app/src/main/java/com/flowfoundation/wallet/manager/token/model/FungibleToken.kt [161-162]
possible bug: "Potential bug in token comparison logic"
Skipped Comments (3)
-
app/src/main/java/com/flowfoundation/wallet/manager/token/FungibleTokenListManager.kt [85-86]
possible issue: "Potential memory leak in listener registration"
-
app/src/main/java/com/flowfoundation/wallet/manager/token/FungibleTokenListManager.kt [230-232]
possible issue: "Potential race condition in cache update"
-
app/src/main/java/com/flowfoundation/wallet/manager/token/model/FungibleToken.kt [79-85]
enhancement: "Improve numeric error handling"
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- b4c77fa: feat: verified token
Files Processed (30)
- app/src/main/AndroidManifest.xml (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/cache/DisplayTokenCacheManager.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/firebase/config/FirebaseConfig.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/manager/LaunchManager.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/account/BalanceManager.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/manager/coin/CoinRateManager.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/manager/coin/CustomTokenManager.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/coin/FlowCoinListManager.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/manager/evm/EVMWalletManager.kt (5 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/evm/Utils.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/flowjvm/CadenceExecutor.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/token/FungibleTokenListManager.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/manager/token/model/FungibleToken.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/network/ApiService.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/network/UserRegisterUtils.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/network/model/EVMTokenListResponse.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/network/model/FlowTokenListResponse.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/Utils.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/dialog/processing/send/SendProcessingViewModel.kt (5 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/dialog/processing/send/presenter/SendProcessingPresenter.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/inbox/InboxViewModel.kt (5 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/inbox/presenter/InboxTokenItemPresenter.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/main/Utils.kt (5 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/profile/subpage/currency/CurrencyViewModel.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/profile/subpage/currency/model/Currency.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/profile/subpage/wallet/childaccountdetail/ChildAccountDetailViewModel.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/scan/Utils.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/send/transaction/TransactionSendActivity.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/send/transaction/subpage/amount/SendAmountActivity.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/send/transaction/subpage/amount/SendAmountViewModel.kt (3 hunks)
Actionable Comments (2)
-
app/src/main/java/com/flowfoundation/wallet/manager/token/model/FungibleToken.kt [156-158]
possible bug: "Fix incorrect self-comparison in token equality check"
-
app/src/main/java/com/flowfoundation/wallet/manager/token/FungibleTokenListManager.kt [228-232]
possible issue: "Potential race condition in token list update"
Skipped Comments (2)
-
app/src/main/java/com/flowfoundation/wallet/manager/token/FungibleTokenListManager.kt [167-171]
enhancement: "Improve error handling in token list update"
-
app/src/main/java/com/flowfoundation/wallet/manager/token/model/FungibleToken.kt [74-80]
best practice: "Add validation for token balance parsing"
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- c3dcb9a: feat: token detail verified info
Files Processed (1)
- app/src/main/java/com/flowfoundation/wallet/manager/token/model/FungibleToken.kt (1 hunk)
Actionable Comments (1)
-
app/src/main/java/com/flowfoundation/wallet/manager/token/model/FungibleToken.kt [63-65]
possible bug: "Potential null pointer exception in contract ID generation"
Skipped Comments (2)
-
app/src/main/java/com/flowfoundation/wallet/manager/token/model/FungibleToken.kt [107-109]
best practice: "Hardcoded URL in token icon fallback"
-
app/src/main/java/com/flowfoundation/wallet/manager/token/model/FungibleToken.kt [149-149]
readability: "Double negative condition reduces readability"
Comment on lines
+63
to
+65
| fun contractId(): String { | ||
| return "A.${tokenAddress().removeAddressPrefix()}.${tokenContractName()}" | ||
| } |
There was a problem hiding this comment.
The contractId() function assumes both tokenAddress() and tokenContractName() return non-empty strings. However, for EVM tokens, tokenContractName() returns an empty string which could lead to malformed contract IDs. Consider adding null/empty checks or handling EVM tokens differently.
lmcmz
approved these changes
May 9, 2025
|
|
||
| private fun onConfigLoadFinish() { | ||
| FlowCoinListManager.reload() | ||
| // FlowCoinListManager.reload() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #809 #810 #811 #812
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)