Conversation
PR SummaryRefactored the token management system by removing legacy token state management and introducing a new verified token system. Improved token list handling, added verification status indicators, and streamlined token price formatting. Removed currency conversion complexity from price formatting utilities. Changes
autogenerated by presubmit.ai |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- 78f34f2: fix: verified token issues
Files Processed (30)
- app/src/main/java/com/flowfoundation/wallet/cache/CacheConst.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/firebase/config/FirebaseConfig.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/LaunchManager.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/coin/CustomTokenManager.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/coin/FlowCoinListManager.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/manager/coin/TokenStateManager.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/manager/flowjvm/CadenceExecutor.kt (5 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/token/FungibleTokenListManager.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/transaction/TransactionStateManager.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/network/ApiService.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/network/UserRegisterUtils.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/network/model/AddTokenListResponse.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/main/Utils.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/profile/subpage/wallet/WalletListActivity.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/send/transaction/subpage/amount/presenter/SendAmountPresenter.kt (4 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/send/transaction/subpage/amount/widget/SendCoinPopupMenu.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/send/transaction/subpage/transaction/presenter/TransactionPresenter.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/token/addtoken/AddTokenActivity.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/token/addtoken/AddTokenConfirmDialog.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/token/addtoken/AddTokenViewModel.kt (5 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/token/addtoken/adapter/TokenListAdapter.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/token/addtoken/model/TokenItem.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/token/addtoken/presenter/AddTokenPresenter.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/token/addtoken/presenter/TokenItemPresenter.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/token/custom/model/CustomTokenItem.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/token/detail/TokenDetailActivity.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/token/detail/Utils.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/token/detail/presenter/TokenDetailPresenter.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/token/detail/widget/ChartMarker.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/utils/CoinUtils.kt (3 hunks)
Actionable Comments (1)
-
app/src/main/java/com/flowfoundation/wallet/page/token/addtoken/AddTokenViewModel.kt [44-48]
possible issue: "Missing error handling for API response"
Skipped Comments (1)
-
app/src/main/java/com/flowfoundation/wallet/manager/token/FungibleTokenListManager.kt [228-231]
best practice: "Consider using a constant for dust token threshold"
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 7addc63: fix: coin utils test failure
Files Processed (1)
- app/src/main/java/com/flowfoundation/wallet/utils/CoinUtils.kt (4 hunks)
Actionable Comments (0)
Skipped Comments (2)
-
app/src/main/java/com/flowfoundation/wallet/utils/CoinUtils.kt [18-19]
possible issue: "Consider adding validation for negative values"
-
app/src/main/java/com/flowfoundation/wallet/utils/CoinUtils.kt [16-16]
enhancement: "Unnecessary variable assignment"
lmcmz
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #1036
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)