Hot fix - telegram deep linking (#1074)#1076
Conversation
* Hot fix - telegram deep linking * Hot fix - telegram deep linking * Hot fix - telegram deep linking * Hot fix - telegram deep linking * Hot fix - telegram deep linking * Hot fix - telegram deep linking * WC deep linking * WC deep linking
PR SummaryEnhanced deep linking functionality by adding support for Telegram deep links and improving WalletConnect URI handling. Added window color customization through JavaScript interface and improved error handling for unsupported apps. The changes include better URI scheme handling for 'frw' and 'fcw' protocols and proper Telegram app detection. Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
-
Hot fix - telegram deep linking
-
Hot fix - telegram deep linking
-
Hot fix - telegram deep linking
-
Hot fix - telegram deep linking
-
Hot fix - telegram deep linking
-
Hot fix - telegram deep linking
-
WC deep linking
-
WC deep linking
Files Processed (4)
- app/src/main/java/com/flowfoundation/wallet/page/browser/widgets/LilicoWebView.kt (11 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/Utils.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/widgets/webview/JsInterface.kt (1 hunk)
- app/src/main/res/values/strings.xml (1 hunk)
Actionable Comments (1)
-
app/src/main/java/com/flowfoundation/wallet/widgets/webview/JsInterface.kt [54-56]
possible bug: "Potential crash when parsing invalid color string"
Skipped Comments (1)
-
app/src/main/java/com/flowfoundation/wallet/page/browser/widgets/LilicoWebView.kt [307-311]
best practice: "Missing activity resolution check before starting Telegram intent"
| if (color.startsWith("#")) { | ||
| val colorInt = android.graphics.Color.parseColor(color) | ||
| uiScope { |
There was a problem hiding this comment.
The color parsing could throw an IllegalArgumentException for invalid color formats. Consider adding validation for the color string format before parsing:
if (color.matches("^#([A-Fa-f0-9]{6}|[A-Fa-f0-9]{8})$".toRegex())) {
val colorInt = android.graphics.Color.parseColor(color)
// ... rest of the code
}
Related Issue
Closes #???
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)