Skip to content

Hot fix - telegram deep linking (#1074)#1076

Merged
lealobanov merged 1 commit intomasterfrom
develop
May 16, 2025
Merged

Hot fix - telegram deep linking (#1074)#1076
lealobanov merged 1 commit intomasterfrom
develop

Conversation

@lealobanov
Copy link
Copy Markdown
Contributor

@lealobanov lealobanov commented May 16, 2025

  • Hot fix - telegram deep linking

Related Issue

Closes #???

Summary of Changes

Need Regression Testing

  • Yes
  • No

Risk Assessment

  • Low
  • Medium
  • High

Additional Notes

Screenshots (if applicable)

* Hot fix - telegram deep linking

* Hot fix - telegram deep linking

* Hot fix - telegram deep linking

* Hot fix - telegram deep linking

* Hot fix - telegram deep linking

* Hot fix - telegram deep linking

* WC deep linking

* WC deep linking
@lealobanov lealobanov requested a review from a team as a code owner May 16, 2025 09:51
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 16, 2025

PR Summary

Enhanced deep linking functionality by adding support for Telegram deep links and improving WalletConnect URI handling. Added window color customization through JavaScript interface and improved error handling for unsupported apps. The changes include better URI scheme handling for 'frw' and 'fcw' protocols and proper Telegram app detection.

Changes

File Summary
app/src/main/java/com/flowfoundation/wallet/page/browser/widgets/LilicoWebView.kt Added support for Telegram deep links and improved WalletConnect URI handling. Added new URL scheme handlers for 'frw' and 'fcw' protocols, enhanced error handling, and added activity not found handling for Telegram app.
app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/Utils.kt Added special handling for Telegram URIs and enhanced WalletConnect link processing. Added support for direct WalletConnect links from Lilico.app domains with proper URL decoding.
app/src/main/java/com/flowfoundation/wallet/widgets/webview/JsInterface.kt Implemented new windowColor JavaScript interface method to allow dynamic window color changes from web content, with proper color parsing and error handling.
app/src/main/res/values/strings.xml Added new string resource telegram_not_installed for displaying when Telegram app is not installed on the device.

autogenerated by presubmit.ai

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 Pull request needs attention.

Review Summary

Commits Considered (1)
  • Hot fix - telegram deep linking

  • Hot fix - telegram deep linking

  • Hot fix - telegram deep linking

  • Hot fix - telegram deep linking

  • Hot fix - telegram deep linking

  • Hot fix - telegram deep linking

  • WC deep linking

  • WC deep linking

Files Processed (4)
  • app/src/main/java/com/flowfoundation/wallet/page/browser/widgets/LilicoWebView.kt (11 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/Utils.kt (1 hunk)
  • app/src/main/java/com/flowfoundation/wallet/widgets/webview/JsInterface.kt (1 hunk)
  • app/src/main/res/values/strings.xml (1 hunk)
Actionable Comments (1)
  • app/src/main/java/com/flowfoundation/wallet/widgets/webview/JsInterface.kt [54-56]

    possible bug: "Potential crash when parsing invalid color string"

Skipped Comments (1)
  • app/src/main/java/com/flowfoundation/wallet/page/browser/widgets/LilicoWebView.kt [307-311]

    best practice: "Missing activity resolution check before starting Telegram intent"

Comment on lines +54 to +56
if (color.startsWith("#")) {
val colorInt = android.graphics.Color.parseColor(color)
uiScope {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The color parsing could throw an IllegalArgumentException for invalid color formats. Consider adding validation for the color string format before parsing:

if (color.matches("^#([A-Fa-f0-9]{6}|[A-Fa-f0-9]{8})$".toRegex())) {
    val colorInt = android.graphics.Color.parseColor(color)
    // ... rest of the code
}

@lealobanov lealobanov merged commit 9208679 into master May 16, 2025
6 checks passed
@github-actions github-actions Bot mentioned this pull request May 28, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants