Skip to content

Fix UI#1115

Merged
jaymengxy merged 2 commits intodevelopfrom
fix_ui
May 28, 2025
Merged

Fix UI#1115
jaymengxy merged 2 commits intodevelopfrom
fix_ui

Conversation

@jaymengxy
Copy link
Copy Markdown
Contributor

Related Issue

Closes #1107 #1106

Summary of Changes

Need Regression Testing

  • Yes
  • No

Risk Assessment

  • Low
  • Medium
  • High

Additional Notes

Screenshots (if applicable)

@jaymengxy jaymengxy added this to the Release 2.8.6 milestone May 28, 2025
@jaymengxy jaymengxy self-assigned this May 28, 2025
@jaymengxy jaymengxy requested a review from a team as a code owner May 28, 2025 04:26
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 28, 2025

PR Summary

Enhanced the user interface for address book and account key list functionality. Updated the address book dialog background, improved account key list swipe behavior for revoked keys, and modified visual elements. Also bumped app version to r2.8.6.

Changes

File Summary
app/src/main/java/com/flowfoundation/wallet/page/address/presenter/AddressBookPersonPresenter.kt Added background color resource (R.color.background) to the address action dialog window to improve visual consistency.
app/src/main/java/com/flowfoundation/wallet/page/profile/subpage/wallet/key/presenter/AccountKeyListItemPresenter.kt Changed default expansion state to true, added swipe lock for revoked/revoking keys, and fixed toggle icon behavior. Enhanced user experience by preventing swipe actions on invalid states.
app/src/main/res/layout/activity_add_address.xml Modified save button appearance by changing text color to @color/text and removing explicit background tint while maintaining corner radius.
app/src/main/res/layout/layout_key_list_item.xml Updated the default icon source from expand to collapse (@drawable/ic_key_list_collapse) to match the new default expanded state.
gradle.properties Increased version code from 290 to 295 and version name from r2.8.5 to r2.8.6.

autogenerated by presubmit.ai

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 Pull request needs attention.

Review Summary

Commits Considered (2)
  • 1ba6458: fix: account key list swipe
  • 62af6c5: fix: address book ui style
Files Processed (5)
  • app/src/main/java/com/flowfoundation/wallet/page/address/presenter/AddressBookPersonPresenter.kt (1 hunk)
  • app/src/main/java/com/flowfoundation/wallet/page/profile/subpage/wallet/key/presenter/AccountKeyListItemPresenter.kt (3 hunks)
  • app/src/main/res/layout/activity_add_address.xml (1 hunk)
  • app/src/main/res/layout/layout_key_list_item.xml (1 hunk)
  • gradle.properties (1 hunk)
Actionable Comments (1)
  • app/src/main/java/com/flowfoundation/wallet/page/profile/subpage/wallet/key/presenter/AccountKeyListItemPresenter.kt [86-91]

    possible bug: "Swipe layout state not restored on rebind"

Skipped Comments (1)
  • app/src/main/java/com/flowfoundation/wallet/page/profile/subpage/wallet/key/presenter/AccountKeyListItemPresenter.kt [26-26]

    possible issue: "Default expanded state may affect user experience"

@jaymengxy jaymengxy linked an issue May 28, 2025 that may be closed by this pull request
@jaymengxy jaymengxy merged commit 0b31a4f into develop May 28, 2025
3 checks passed
@jaymengxy jaymengxy deleted the fix_ui branch May 28, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] UI improvements on Account Keys page [BUG] Address book UI components not visible on dark mode

2 participants