Skip to content

fix: duplicate token list#1173

Merged
jaymengxy merged 1 commit intodevelopfrom
fix_token_list
Jun 10, 2025
Merged

fix: duplicate token list#1173
jaymengxy merged 1 commit intodevelopfrom
fix_token_list

Conversation

@jaymengxy
Copy link
Copy Markdown
Contributor

Related Issue

Closes #1165

Summary of Changes

Need Regression Testing

  • Yes
  • No

Risk Assessment

  • Low
  • Medium
  • High

Additional Notes

Screenshots (if applicable)

@jaymengxy jaymengxy self-assigned this Jun 10, 2025
@jaymengxy jaymengxy requested a review from a team as a code owner June 10, 2025 09:45
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 10, 2025

PR Summary

Fixed an issue where duplicate tokens could appear in the token list by ensuring unique tokens based on their contract ID. The fix was applied to both cached and fresh token list loading scenarios. Also incremented the version code for the new release.

Changes

File Summary
app/src/main/java/com/flowfoundation/wallet/manager/token/FungibleTokenListManager.kt Modified token list management to prevent duplicates by using distinctBy { it.contractId() } when adding tokens from cache, fresh provider data, and during list updates.
gradle.properties Incremented version code from 298 to 299 while maintaining version name at r2.8.7

autogenerated by presubmit.ai

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (1)
  • c82f77f: fix: duplicate token list
Files Processed (2)
  • app/src/main/java/com/flowfoundation/wallet/manager/token/FungibleTokenListManager.kt (3 hunks)
  • gradle.properties (1 hunk)
Actionable Comments (0)
Skipped Comments (2)
  • app/src/main/java/com/flowfoundation/wallet/manager/token/FungibleTokenListManager.kt [142-142]

    maintainability: "Reduce code duplication by extracting repeated operation"

  • app/src/main/java/com/flowfoundation/wallet/manager/token/FungibleTokenListManager.kt [178-178]

    best practice: "Apply deduplication earlier in the data flow"

@jaymengxy jaymengxy merged commit 2dd00eb into develop Jun 10, 2025
3 checks passed
@jaymengxy jaymengxy deleted the fix_token_list branch June 10, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate flow tokens shown in evm account

2 participants