Skip to content

Conversation

@lealobanov
Copy link
Collaborator

Related Issue

Add UI handling for TX error message

Summary of Changes

Need Regression Testing

  • Yes
  • No

Risk Assessment

  • Low
  • Medium
  • High

Additional Notes

Screenshots (if applicable)

@lealobanov lealobanov requested a review from a team as a code owner July 7, 2025 08:22
@github-actions
Copy link

github-actions bot commented Jul 7, 2025

PR Summary

Enhanced transaction status validation by incorporating error message checks across different transaction types. Updated the success criteria to ensure transactions are only considered successful when both execution status is successful AND error message is blank. This improvement affects regular transactions, bridge transactions, and multi-signature transactions.

Changes

File Summary
app/build.gradle Upgraded com.github.onflow.flow-kmm:flow dependency from version 0.0.24 to 0.0.25 to support new error handling features.
app/src/main/java/com/flowfoundation/wallet/manager/flowjvm/transaction/Transaction.kt Enhanced transaction success validation in sendTransaction, sendBridgeTransaction, and sendTransactionWithMultiSignature methods by adding errorMessage.isBlank() check alongside execution status for FINALIZED, SEALED, and EXECUTED states.

autogenerated by presubmit.ai

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 Pull request needs attention.

Review Summary

Commits Considered (2)
  • e3f967a: Error handling for tx status with error message
  • ffa8fad: Bump flow-kmm
Files Processed (2)
  • app/build.gradle (1 hunk)
  • app/src/main/java/com/flowfoundation/wallet/manager/flowjvm/transaction/Transaction.kt (3 hunks)
Actionable Comments (1)
  • app/build.gradle [369-369]

    possible issue: "Version upgrade might introduce breaking changes"

Skipped Comments (2)
  • app/src/main/java/com/flowfoundation/wallet/manager/flowjvm/transaction/Transaction.kt [98-99]

    enhancement: "Consider handling non-blank error messages"

  • app/src/main/java/com/flowfoundation/wallet/manager/flowjvm/transaction/Transaction.kt [95-104]

    maintainability: "Duplicate transaction status handling logic"

exclude group: 'org.bouncycastle', module: 'bcprov-jdk15on'
}
implementation 'com.github.onflow.flow-kmm:flow:0.0.24'
implementation 'com.github.onflow.flow-kmm:flow:0.0.25'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Flow KMM SDK is being upgraded from version 0.0.24 to 0.0.25. Given the early version numbers (0.0.x), this could potentially introduce breaking changes. Ensure all SDK functionality is thoroughly tested after this upgrade.

@lealobanov lealobanov merged commit 16b7c87 into develop Jul 7, 2025
2 checks passed
@lealobanov lealobanov deleted the fixed-point-formatter branch July 7, 2025 08:25
@github-actions github-actions bot mentioned this pull request Jul 15, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants