Conversation
PR SummaryRemoved NFT favorite collection functionality and sharing capabilities from the NFT detail page. Simplified the NFT send confirmation flow by removing automatic navigation to the NFT tab after transaction submission. These changes streamline the UI and user experience by focusing on core NFT viewing and transfer functionality. Changes
autogenerated by presubmit.ai |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- c64afea: fix: nft detail ui
Files Processed (2)
- app/src/main/java/com/flowfoundation/wallet/page/nft/nftdetail/presenter/NftDetailPresenter.kt (8 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/send/nft/confirm/presenter/NftSendConfirmPresenter.kt (4 hunks)
Actionable Comments (1)
-
app/src/main/java/com/flowfoundation/wallet/page/send/nft/confirm/presenter/NftSendConfirmPresenter.kt [102-102]
possible bug: "Incomplete dialog dismissal logic"
Skipped Comments (1)
-
app/src/main/java/com/flowfoundation/wallet/page/send/nft/confirm/presenter/NftSendConfirmPresenter.kt [34-34]
possible issue: "Missing error handling in async operation"
| list.add(0, sendModel.target) | ||
| recentCache.contacts = list | ||
| recentTransactionCache().cache(recentCache) | ||
| uiScope { fragment.dismissAllowingStateLoss() } |
There was a problem hiding this comment.
The dialog is only dismissed on success but there's no handling for the failure case. This could leave the dialog hanging if the transaction fails. Consider adding dialog dismissal logic for both success and failure cases.
2 participants
Related Issue
Closes #1241
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)