Skip to content

Setup unit tests#695

Merged
lealobanov merged 41 commits intodevelopfrom
wip-unit-tests
Apr 3, 2025
Merged

Setup unit tests#695
lealobanov merged 41 commits intodevelopfrom
wip-unit-tests

Conversation

@lealobanov
Copy link
Copy Markdown
Contributor

@lealobanov lealobanov commented Mar 11, 2025

Related Issue

  • Enable unit tests to run in GH actions CI
  • Fix the existing "Hello world" unit test to pass
  • Start generating unit tests using Cursor (started with the utils classes as an example)
  • Implement code coverage reporting? For now we can choose to not fail the build due to low code coverage as we have little tests. But would be good to keep an eye on the stats as we add tests

Summary of Changes

This PR begins setting up unit testing on the repo, starting with utils classes.

Need Regression Testing

  • Yes
  • No

Risk Assessment

  • Low
  • Medium
  • High

Additional Notes

Screenshots (if applicable)

@lealobanov lealobanov changed the title Wip unit tests Wip/ Setup unit tests Mar 11, 2025
@lealobanov lealobanov changed the title Wip/ Setup unit tests Setup unit tests Mar 13, 2025
@lealobanov lealobanov marked this pull request as ready for review March 13, 2025 19:40
@lealobanov lealobanov requested review from jaymengxy and lmcmz and removed request for jaymengxy March 13, 2025 19:44
@lealobanov lealobanov requested a review from a team March 24, 2025 21:26
Comment thread app/build.gradle
testImplementation "io.mockk:mockk:1.13.9"
testImplementation "org.robolectric:robolectric:4.11.1"
testImplementation 'junit:junit:4.13.2'
androidTestImplementation 'androidx.test.ext:junit:1.1.5'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some duplicate implementation

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated - thanks

jaymengxy
jaymengxy previously approved these changes Apr 1, 2025
Base automatically changed from linting to develop April 1, 2025 16:22
@lealobanov lealobanov dismissed jaymengxy’s stale review April 1, 2025 16:22

The base branch was changed.

@lealobanov lealobanov requested a review from jaymengxy April 2, 2025 21:54
@lealobanov
Copy link
Copy Markdown
Contributor Author

@jaymengxy I have resolved all the merge conflicts and gotten this branch up to date with the latest state of develop branch. Ready for re-review now. Thanks!

@lealobanov lealobanov self-assigned this Apr 2, 2025
@lealobanov lealobanov merged commit 721208a into develop Apr 3, 2025
3 checks passed
@lealobanov lealobanov deleted the wip-unit-tests branch April 3, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants