Skip to content

Instabug 64/ Debug crash in WebView dropdown #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lealobanov merged 7 commits into from
May 19, 2025
Merged

Instabug 64/ Debug crash in WebView dropdown #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5f3bf05
Debug crash in WebView dropdown
lealobanov Mar 18, 2025
0b384ae
Pull latest changes
lealobanov May 19, 2025
b339d93
Bump CrowdIn to latest
lealobanov May 19, 2025
8851556
Bump CrowdIn to latest
lealobanov May 19, 2025
f0ef454
Bump CrowdIn to latest
lealobanov May 19, 2025
b3862f4
Bump CrowdIn to latest
lealobanov May 19, 2025
24048f2
Bump CrowdIn to latest
lealobanov May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ dependencies {
implementation 'com.dropbox.core:dropbox-android-sdk:7.0.0'

/** Crowdin **/
implementation ('com.github.crowdin.mobile-sdk-android:sdk:1.9.2') {
implementation ('com.github.crowdin.mobile-sdk-android:sdk:1.13.1') {
exclude group: 'com.google.code.gson', module: 'gson'
}

Expand Down
2 changes: 2 additions & 0 deletions app/src/main/java/com/flowfoundation/wallet/FlowWalletApplication.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package com.flowfoundation.wallet

import android.app.Application
import com.flowfoundation.wallet.crowdin.crowdinInitialize
import com.flowfoundation.wallet.manager.LaunchManager
import com.flowfoundation.wallet.utils.Env

Expand All @@ -9,6 +10,7 @@ class FlowWalletApplication : Application() {
override fun onCreate() {
super.onCreate()
Env.init(this)
crowdinInitialize(this)
LaunchManager.init(this)
}
}
1 change: 0 additions & 1 deletion app/src/main/java/com/flowfoundation/wallet/crowdin/CrowdinUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import com.crowdin.platform.CrowdinConfig
import com.crowdin.platform.data.remote.NetworkType
import com.flowfoundation.wallet.BuildConfig


fun crowdinInitialize(application: Application) {
Crowdin.init(application,
CrowdinConfig.Builder()
Expand Down
7 changes: 4 additions & 3 deletions app/src/main/java/com/flowfoundation/wallet/page/browser/widgets/LilicoWebView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import android.widget.FrameLayout
import android.widget.TextView
import android.widget.Toast
import androidx.annotation.ColorInt
import com.crowdin.platform.Crowdin
import com.flowfoundation.wallet.BuildConfig
import com.flowfoundation.wallet.R
import com.flowfoundation.wallet.manager.blocklist.BlockManager
Expand Down Expand Up @@ -55,16 +56,16 @@ class LilicoWebView : WebView {

private var blockedUrl: String? = null

constructor(context: Context) : super(context) {
constructor(context: Context) : super(Crowdin.wrapContext(context)) {
initWebView()
}

constructor(context: Context, attrs: AttributeSet?) : super(context, attrs) {
constructor(context: Context, attrs: AttributeSet?) : super(Crowdin.wrapContext(context), attrs) {
initWebView()
}

constructor(context: Context, attrs: AttributeSet?, defStyleAttr: Int) : super(
context,
Crowdin.wrapContext(context),
attrs,
defStyleAttr
) {
Comment on lines 67 to 71
Copy link
Copy Markdown

@github-actions github-actions Bot May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The third constructor is missing initWebView() call that is present in the other two constructors. This inconsistency could lead to incomplete initialization of the WebView when using this constructor.

Expand Down
5 changes: 0 additions & 5 deletions ...src/main/java/com/flowfoundation/wallet/page/component/deeplinking/DeepLinkingActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,6 @@ class DeepLinkingActivity : BaseActivity() {
}
}

override fun onPause() {
super.onPause()
// Don't finish here, let the coroutine handle it
}

private fun isWalletConnectUri(uri: Uri): Boolean {
return try {
val uriString = uri.toString()
Comment on lines 81 to 82
Copy link
Copy Markdown

@github-actions github-actions Bot May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The isWalletConnectUri() method has a try block but the corresponding catch block is not shown in the diff. Ensure proper exception handling is implemented to avoid potential crashes when parsing invalid URIs.

Expand Down