Merged
Conversation
lealobanov
reviewed
Apr 7, 2025
|
|
||
| fun Voucher.toFlowTransactionWithBridgePayer(): FlowTransaction { | ||
| val transaction = this | ||
| var tx = flowTransaction { |
Contributor
There was a problem hiding this comment.
If it won't break the current implementation, it would be good use to the the Transaction class from flow-kmm instead of the transaction-DSL from flow-JVM in this function. If it causes too many downstream changes I can refactor it on my end in the upcoming PR. Thanks!
Contributor
Author
There was a problem hiding this comment.
This is just to create a special Transaction. At present, the logic related to the Transaction is still implemented using the flow-jvm. I think we can replace this whole part of the logic with flow-kmm later.
lealobanov
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #757
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)