Skip to content

FWK release version#779

Merged
lmcmz merged 3 commits intodevelopfrom
fwk-gh-action
Apr 10, 2025
Merged

FWK release version#779
lmcmz merged 3 commits intodevelopfrom
fwk-gh-action

Conversation

@lealobanov
Copy link
Copy Markdown
Contributor

Related Issue

Point FWK to latest stable version

Summary of Changes

Need Regression Testing

  • Yes
  • No

Risk Assessment

  • Low
  • Medium
  • High

Additional Notes

Screenshots (if applicable)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2025

PR Summary

Updated GitHub Actions workflows to use a specific stable version of Flow Wallet Kit (FWK) by pinning it to commit 0c00c994c93f18d9558ba7a953177a3f4a6f5d76. This change affects both PR build and release workflows, ensuring consistent dependency versioning across the CI/CD pipeline.

Changes

File Summary
.github/workflows/pr-build.yml Modified the Flow Wallet Kit checkout step to use specific commit 0c00c994c93f18d9558ba7a953177a3f4a6f5d76 instead of the default branch, ensuring stable version for PR builds.
.github/workflows/release.yml Modified the Flow Wallet Kit checkout step to use specific commit 0c00c994c93f18d9558ba7a953177a3f4a6f5d76 instead of the default branch, ensuring stable version for releases.

autogenerated by presubmit.ai

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (2)
  • 99ca40d: Point FWK to latest stable version
  • b67ed0f: Point FWK to latest stable version
Files Processed (2)
  • .github/workflows/pr-build.yml (1 hunk)
  • .github/workflows/release.yml (1 hunk)
Actionable Comments (0)
Skipped Comments (1)
  • .github/workflows/pr-build.yml [16-21]

    best practice: "Consider using a version tag instead of a commit hash"

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (1)
  • 7cef230: Merge branch 'develop' into fwk-gh-action
Files Processed (2)
  • .github/workflows/pr-build.yml (1 hunk)
  • .github/workflows/release.yml (1 hunk)
Actionable Comments (0)
Skipped Comments (1)
  • .github/workflows/pr-build.yml [16-21]

    best practice: "Consider using a version tag instead of a commit hash"

@lealobanov lealobanov requested a review from a team April 9, 2025 23:26
@lmcmz lmcmz merged commit 29f598b into develop Apr 10, 2025
3 checks passed
@lmcmz lmcmz deleted the fwk-gh-action branch April 10, 2025 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants