Conversation
PR SummaryAdded a new BlockManager to check websites against a community-maintained blocklist. Implemented warning UI components and dialogs to alert users when accessing potentially dangerous websites. Added timeout for network requests and localized warning messages across multiple languages. Changes
autogenerated by presubmit.ai |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- 48c033e: feat: check block list
Files Processed (30)
- app/src/main/java/com/flowfoundation/wallet/manager/LaunchManager.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/blocklist/BlockManager.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/browser/widgets/LilicoWebView.kt (5 hunks)
- app/src/main/java/com/flowfoundation/wallet/widgets/webview/evm/dialog/EVMSignMessageDialog.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/widgets/webview/evm/dialog/EVMSignTypedDataDialog.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/widgets/webview/evm/dialog/EvmRequestAccountDialog.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/widgets/webview/fcl/dialog/FclAuthnDialog.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/widgets/webview/fcl/dialog/FclSignMessageDialog.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/widgets/webview/fcl/dialog/authz/FclAuthzView.kt (2 hunks)
- app/src/main/res/drawable/bg_blocked_connect_layout.xml (1 hunk)
- app/src/main/res/drawable/bg_blocked_layout.xml (1 hunk)
- app/src/main/res/drawable/ic_blocked.xml (1 hunk)
- app/src/main/res/layout/dialog_evm_account.xml (5 hunks)
- app/src/main/res/layout/dialog_evm_sign_typed_data.xml (1 hunk)
- app/src/main/res/layout/dialog_fcl_authn.xml (3 hunks)
- app/src/main/res/layout/dialog_fcl_authz.xml (1 hunk)
- app/src/main/res/layout/dialog_fcl_sign_message.xml (2 hunks)
- app/src/main/res/layout/layout_blocked_connect.xml (1 hunk)
- app/src/main/res/layout/layout_blocked_tip.xml (1 hunk)
- app/src/main/res/layout/layout_blocked_view.xml (1 hunk)
- app/src/main/res/values-de-rDE/strings.xml (3 hunks)
- app/src/main/res/values-en-rUS/strings.xml (7 hunks)
- app/src/main/res/values-es-rES/strings.xml (4 hunks)
- app/src/main/res/values-es-rUS/strings.xml (4 hunks)
- app/src/main/res/values-fr-rFR/strings.xml (4 hunks)
- app/src/main/res/values-hi-rIN/strings.xml (14 hunks)
- app/src/main/res/values-it-rIT/strings.xml (4 hunks)
- app/src/main/res/values-ja-rJP/strings.xml (4 hunks)
- app/src/main/res/values-ko-rKR/strings.xml (3 hunks)
- app/src/main/res/values-night/colors.xml (1 hunk)
Actionable Comments (2)
-
app/src/main/java/com/flowfoundation/wallet/manager/blocklist/BlockManager.kt [70-71]
best practice: "Add timeout to network request"
-
app/src/main/java/com/flowfoundation/wallet/manager/blocklist/BlockManager.kt [42-44]
possible issue: "Improve domain matching logic"
Skipped Comments (1)
-
app/src/main/java/com/flowfoundation/wallet/manager/blocklist/BlockManager.kt [15-15]
enhancement: "Make blocklist URL configurable"
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- 894f7b6: fix: add network request time out
Files Processed (1)
- app/src/main/java/com/flowfoundation/wallet/manager/blocklist/BlockManager.kt (1 hunk)
Actionable Comments (1)
-
app/src/main/java/com/flowfoundation/wallet/manager/blocklist/BlockManager.kt [38-42]
bug: "Logic error in domain matching"
Skipped Comments (2)
-
app/src/main/java/com/flowfoundation/wallet/manager/blocklist/BlockManager.kt [64-67]
best practice: "Network request without timeout handling"
-
app/src/main/java/com/flowfoundation/wallet/manager/blocklist/BlockManager.kt [81-81]
best practice: "Using error log for non-error information"
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- d9eeedf: fix: add network request time out
Files Processed (1)
- app/src/main/java/com/flowfoundation/wallet/manager/blocklist/BlockManager.kt (1 hunk)
Actionable Comments (0)
Skipped Comments (3)
-
app/src/main/java/com/flowfoundation/wallet/manager/blocklist/BlockManager.kt [62-64]
best practice: "Network timeouts could be configurable constants"
-
app/src/main/java/com/flowfoundation/wallet/manager/blocklist/BlockManager.kt [42-42]
enhancement: "Exception details are not logged"
-
app/src/main/java/com/flowfoundation/wallet/manager/blocklist/BlockManager.kt [38-38]
performance: "Regular expression could be precompiled"
Contributor
Author
|
|
lmcmz
approved these changes
Apr 11, 2025
|
This feature already added on Android internal test version 253 (i1.8.6). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #767
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)