Skip to content

fix: private key display and move fee#784

Merged
jaymengxy merged 1 commit intodevelopfrom
fix_issues
Apr 11, 2025
Merged

fix: private key display and move fee#784
jaymengxy merged 1 commit intodevelopfrom
fix_issues

Conversation

@jaymengxy
Copy link
Copy Markdown
Contributor

Related Issue

Closes #783

Summary of Changes

Need Regression Testing

  • Yes
  • No

Risk Assessment

  • Low
  • Medium
  • High

Additional Notes

Screenshots (if applicable)

@jaymengxy jaymengxy added this to the Release 2.8.2 milestone Apr 11, 2025
@jaymengxy jaymengxy requested a review from a team April 11, 2025 07:34
@jaymengxy jaymengxy self-assigned this Apr 11, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 11, 2025

PR Summary

Reduced the fixed move fee from 0.001 to 0.0001 FLOW across the application and improved private key handling for different wallet types. Added privacy protection by integrating Instabug private views for sensitive data fields and enhanced the UI for key display screens.

Changes

File Summary
app/src/main/java/com/flowfoundation/wallet/manager/account/AccountInfoManager.kt Decreased FIXED_MOVE_FEE from 0.001 to 0.0001 FLOW while maintaining other constants like MIN_FLOW_BALANCE and AVERAGE_TX_FEE.
app/src/main/java/com/flowfoundation/wallet/page/nft/move/MoveNFTDialog.kt Modified move fee display from 0.001 to 0.0001 FLOW in the NFT movement dialog interface.
app/src/main/java/com/flowfoundation/wallet/page/nft/move/SelectNFTDialog.kt Updated the move fee display from 0.001 to 0.0001 FLOW in the NFT selection dialog.
app/src/main/java/com/flowfoundation/wallet/page/profile/subpage/wallet/WalletSettingActivity.kt Added support for PrivateKeyStoreCryptoProvider in wallet settings, enabling private key access for different wallet types.
app/src/main/java/com/flowfoundation/wallet/page/restore/keystore/PrivateKeyStoreCryptoProvider.kt Implemented new getPrivateKey() method to retrieve private key from keystore address.
app/src/main/java/com/flowfoundation/wallet/page/restore/keystore/fragment/PrivateKeyInfoFragment.kt Added Instabug private view protection for private key input field.
app/src/main/java/com/flowfoundation/wallet/page/restore/keystore/fragment/PrivateKeyStoreInfoFragment.kt Implemented Instabug private views for JSON and password input fields to enhance security.
app/src/main/java/com/flowfoundation/wallet/page/restore/keystore/fragment/SeedPhraseInfoFragment.kt Added Instabug private view protection for seed phrase input field.
app/src/main/java/com/flowfoundation/wallet/page/security/recovery/SecurityPrivateKeyActivity.kt Added support for displaying private keys from PrivateKeyStoreCryptoProvider and improved security with Instabug private views.
app/src/main/java/com/flowfoundation/wallet/page/token/detail/widget/MoveTokenDialog.kt Changed move fee display from 0.001 to 0.0001 FLOW in token movement dialog.
app/src/main/res/layout/activity_security_public_key.xml Added horizontal and top margins to improve the layout spacing of public key display.
app/src/main/res/layout/dialog_move_nft.xml Modified example text in layout from 0.001 to 0.0001 FLOW for consistency.
app/src/main/res/layout/dialog_move_token.xml Changed example text in layout from 0.001 to 0.0001 FLOW for consistency.
app/src/main/res/layout/dialog_select_nft.xml Modified example text in layout from 0.001 to 0.0001 FLOW for consistency.

autogenerated by presubmit.ai

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 Pull request needs attention.

Review Summary

Commits Considered (1)
  • 5be769f: fix: private key display and move fee
Files Processed (14)
  • app/src/main/java/com/flowfoundation/wallet/manager/account/AccountInfoManager.kt (1 hunk)
  • app/src/main/java/com/flowfoundation/wallet/page/nft/move/MoveNFTDialog.kt (1 hunk)
  • app/src/main/java/com/flowfoundation/wallet/page/nft/move/SelectNFTDialog.kt (1 hunk)
  • app/src/main/java/com/flowfoundation/wallet/page/profile/subpage/wallet/WalletSettingActivity.kt (2 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/restore/keystore/PrivateKeyStoreCryptoProvider.kt (1 hunk)
  • app/src/main/java/com/flowfoundation/wallet/page/restore/keystore/fragment/PrivateKeyInfoFragment.kt (2 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/restore/keystore/fragment/PrivateKeyStoreInfoFragment.kt (2 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/restore/keystore/fragment/SeedPhraseInfoFragment.kt (2 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/security/recovery/SecurityPrivateKeyActivity.kt (2 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/token/detail/widget/MoveTokenDialog.kt (1 hunk)
  • app/src/main/res/layout/activity_security_public_key.xml (1 hunk)
  • app/src/main/res/layout/dialog_move_nft.xml (1 hunk)
  • app/src/main/res/layout/dialog_move_token.xml (1 hunk)
  • app/src/main/res/layout/dialog_select_nft.xml (1 hunk)
Actionable Comments (2)
  • app/src/main/java/com/flowfoundation/wallet/page/security/recovery/SecurityPrivateKeyActivity.kt [41-43]

    possible bug: "Potential null pointer exception in private key retrieval"

  • app/src/main/java/com/flowfoundation/wallet/page/restore/keystore/PrivateKeyStoreCryptoProvider.kt [24-26]

    possible bug: "Potential null pointer exception in private key access"

Skipped Comments (1)
  • app/src/main/java/com/flowfoundation/wallet/page/nft/move/MoveNFTDialog.kt [191-191]

    maintainability: "Hardcoded fee value should be referenced from a constant"

@jaymengxy jaymengxy merged commit 154e687 into develop Apr 11, 2025
3 checks passed
@jaymengxy jaymengxy deleted the fix_issues branch April 11, 2025 07:53
@Peppermint1020
Copy link
Copy Markdown

This bug already fixed on Android prod internal test version 253 (i1.8.6)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] PrivateKey display

3 participants