Conversation
PR SummaryReduced the fixed move fee from 0.001 to 0.0001 FLOW across the application and improved private key handling for different wallet types. Added privacy protection by integrating Instabug private views for sensitive data fields and enhanced the UI for key display screens. Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- 5be769f: fix: private key display and move fee
Files Processed (14)
- app/src/main/java/com/flowfoundation/wallet/manager/account/AccountInfoManager.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/nft/move/MoveNFTDialog.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/nft/move/SelectNFTDialog.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/profile/subpage/wallet/WalletSettingActivity.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/restore/keystore/PrivateKeyStoreCryptoProvider.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/restore/keystore/fragment/PrivateKeyInfoFragment.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/restore/keystore/fragment/PrivateKeyStoreInfoFragment.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/restore/keystore/fragment/SeedPhraseInfoFragment.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/security/recovery/SecurityPrivateKeyActivity.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/token/detail/widget/MoveTokenDialog.kt (1 hunk)
- app/src/main/res/layout/activity_security_public_key.xml (1 hunk)
- app/src/main/res/layout/dialog_move_nft.xml (1 hunk)
- app/src/main/res/layout/dialog_move_token.xml (1 hunk)
- app/src/main/res/layout/dialog_select_nft.xml (1 hunk)
Actionable Comments (2)
-
app/src/main/java/com/flowfoundation/wallet/page/security/recovery/SecurityPrivateKeyActivity.kt [41-43]
possible bug: "Potential null pointer exception in private key retrieval"
-
app/src/main/java/com/flowfoundation/wallet/page/restore/keystore/PrivateKeyStoreCryptoProvider.kt [24-26]
possible bug: "Potential null pointer exception in private key access"
Skipped Comments (1)
-
app/src/main/java/com/flowfoundation/wallet/page/nft/move/MoveNFTDialog.kt [191-191]
maintainability: "Hardcoded fee value should be referenced from a constant"
lmcmz
approved these changes
Apr 11, 2025
|
This bug already fixed on Android prod internal test version 253 (i1.8.6) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #783
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)