Skip to content

feat: error code#807

Merged
jaymengxy merged 1 commit intodevelopfrom
error_code
Apr 18, 2025
Merged

feat: error code#807
jaymengxy merged 1 commit intodevelopfrom
error_code

Conversation

@jaymengxy
Copy link
Copy Markdown
Contributor

Related Issue

Closes #764

Summary of Changes

Need Regression Testing

  • Yes
  • No

Risk Assessment

  • Low
  • Medium
  • High

Additional Notes

Screenshots (if applicable)

@jaymengxy jaymengxy added this to the Release 2.8.3 milestone Apr 16, 2025
@jaymengxy jaymengxy self-assigned this Apr 16, 2025
@jaymengxy jaymengxy requested a review from a team as a code owner April 16, 2025 10:41
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2025

Analyzing changes in this PR...

This might take a few minutes, please wait

📥 Commits

Analyzing changes from base (b3d04e4) to latest commit (d789e05):

📁 Files being considered (21)

🔄 app/src/main/java/com/flowfoundation/wallet/cache/AccountCacheManager.kt (2 hunks)
🔄 app/src/main/java/com/flowfoundation/wallet/cache/UserPrefixCacheManager.kt (2 hunks)
🔄 app/src/main/java/com/flowfoundation/wallet/manager/account/AccountManager.kt (6 hunks)
🔄 app/src/main/java/com/flowfoundation/wallet/manager/account/WalletFetcher.kt (2 hunks)
🔄 app/src/main/java/com/flowfoundation/wallet/manager/backup/GoogleDriveBackupUtils.kt (3 hunks)
🔄 app/src/main/java/com/flowfoundation/wallet/manager/cadence/CadenceApiManager.kt (3 hunks)
🔄 app/src/main/java/com/flowfoundation/wallet/manager/drive/GoogleDriveAuthActivity.kt (2 hunks)
🔄 app/src/main/java/com/flowfoundation/wallet/manager/dropbox/DropboxBackupUtils.kt (3 hunks)
🔄 app/src/main/java/com/flowfoundation/wallet/manager/evm/EVMWalletManager.kt (5 hunks)
🔄 app/src/main/java/com/flowfoundation/wallet/manager/flowjvm/CadenceExecutor.kt (2 hunks)
🔄 app/src/main/java/com/flowfoundation/wallet/manager/staking/StakingManager.kt (6 hunks)
🔄 app/src/main/java/com/flowfoundation/wallet/network/UserRegisterUtils.kt (3 hunks)
🔄 app/src/main/java/com/flowfoundation/wallet/page/backup/multibackup/viewmodel/BackupDropboxViewModel.kt (3 hunks)
🔄 app/src/main/java/com/flowfoundation/wallet/page/backup/multibackup/viewmodel/BackupGoogleDriveViewModel.kt (4 hunks)
🔄 app/src/main/java/com/flowfoundation/wallet/page/backup/multibackup/viewmodel/BackupRecoveryPhraseViewModel.kt (3 hunks)
🔄 app/src/main/java/com/flowfoundation/wallet/page/backup/viewmodel/BackupSeedPhraseViewModel.kt (3 hunks)
🔄 app/src/main/java/com/flowfoundation/wallet/page/restore/keystore/viewmodel/KeyStoreRestoreViewModel.kt (8 hunks)
🔄 app/src/main/java/com/flowfoundation/wallet/page/restore/multirestore/viewmodel/MultiRestoreViewModel.kt (4 hunks)
🔄 app/src/main/java/com/flowfoundation/wallet/page/wallet/confirm/presenter/WalletConfirmPresenter.kt (2 hunks)
🔄 app/src/main/java/com/flowfoundation/wallet/utils/error/Error.kt (1 hunk)
🔄 app/src/main/java/com/flowfoundation/wallet/utils/error/ErrorReporter.kt (2 hunks)


autogenerated by presubmit.ai

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (1)
Files Processed (22)
  • app/src/main/java/com/flowfoundation/wallet/cache/AccountCacheManager.kt (2 hunks)
  • app/src/main/java/com/flowfoundation/wallet/cache/UserPrefixCacheManager.kt (2 hunks)
  • app/src/main/java/com/flowfoundation/wallet/manager/account/AccountManager.kt (6 hunks)
  • app/src/main/java/com/flowfoundation/wallet/manager/account/WalletFetcher.kt (2 hunks)
  • app/src/main/java/com/flowfoundation/wallet/manager/backup/GoogleDriveBackupUtils.kt (3 hunks)
  • app/src/main/java/com/flowfoundation/wallet/manager/cadence/CadenceApiManager.kt (3 hunks)
  • app/src/main/java/com/flowfoundation/wallet/manager/drive/GoogleDriveAuthActivity.kt (2 hunks)
  • app/src/main/java/com/flowfoundation/wallet/manager/dropbox/DropboxBackupUtils.kt (3 hunks)
  • app/src/main/java/com/flowfoundation/wallet/manager/evm/EVMWalletManager.kt (5 hunks)
  • app/src/main/java/com/flowfoundation/wallet/manager/flowjvm/CadenceExecutor.kt (2 hunks)
  • app/src/main/java/com/flowfoundation/wallet/manager/staking/StakingManager.kt (6 hunks)
  • app/src/main/java/com/flowfoundation/wallet/network/UserRegisterUtils.kt (3 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/backup/multibackup/viewmodel/BackupDropboxViewModel.kt (3 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/backup/multibackup/viewmodel/BackupGoogleDriveViewModel.kt (4 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/backup/multibackup/viewmodel/BackupRecoveryPhraseViewModel.kt (3 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/backup/viewmodel/BackupSeedPhraseViewModel.kt (3 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/nft/nftlist/utils/NftListRequester.kt (1 hunk)
  • app/src/main/java/com/flowfoundation/wallet/page/restore/keystore/viewmodel/KeyStoreRestoreViewModel.kt (8 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/restore/multirestore/viewmodel/MultiRestoreViewModel.kt (4 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/wallet/confirm/presenter/WalletConfirmPresenter.kt (2 hunks)
  • app/src/main/java/com/flowfoundation/wallet/utils/error/Error.kt (1 hunk)
  • app/src/main/java/com/flowfoundation/wallet/utils/error/ErrorReporter.kt (2 hunks)
Actionable Comments (0)
Skipped Comments (3)
  • app/src/main/java/com/flowfoundation/wallet/manager/evm/EVMWalletManager.kt [81-82]

    best practice: "Private function exposed through public property"

  • app/src/main/java/com/flowfoundation/wallet/manager/flowjvm/CadenceExecutor.kt [770-772]

    enhancement: "Improve error handling by storing exception before logging"

  • app/src/main/java/com/flowfoundation/wallet/page/restore/keystore/viewmodel/KeyStoreRestoreViewModel.kt [238-243]

    best practice: "Consider adding error details to error reporting"

@jaymengxy jaymengxy merged commit 2c9d368 into develop Apr 18, 2025
2 of 3 checks passed
@jaymengxy jaymengxy deleted the error_code branch April 18, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Android Error Code

2 participants