Conversation
PR SummaryEnhanced the app's deep linking capabilities by implementing support for handling dapp, send, and buy actions through deep links. Added network switching functionality and pending action management to handle deep links when network changes are required. The implementation includes URI parsing, value handling, and proper state management across app navigation. Changes
autogenerated by presubmit.ai |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- f32705c: feat: use deeplink
Files Processed (9)
- app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/DeepLinkingActivity.kt (4 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/PendingActionHelper.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/Utils.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/main/MainActivity.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/send/transaction/subpage/amount/SendAmountActivity.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/send/transaction/subpage/amount/SendAmountViewModel.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/send/transaction/subpage/amount/presenter/SendAmountPresenter.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/widgets/SwitchNetworkDialog.kt (3 hunks)
- app/src/main/res/values/strings.xml (1 hunk)
Actionable Comments (1)
-
app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/PendingActionHelper.kt [18-23]
best practice: "Use synchronous SharedPreferences commit for critical data"
Skipped Comments (2)
-
app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/Utils.kt [98-111]
enhancement: "Silent failure in value parsing could confuse users"
-
app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/Utils.kt [124-133]
possible issue: "Network validation could be bypassed if activity is null"
lmcmz
suggested changes
Apr 23, 2025
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Files Processed (5)
- app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/DeepLinkingActivity.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/PendingActionHelper.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/Utils.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/main/MainActivity.kt (3 hunks)
- gradle.properties (1 hunk)
Actionable Comments (2)
-
app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/Utils.kt [122-136]
possible issue: "Add overflow protection in value parsing"
-
app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/Utils.kt [64-69]
best practice: "Add address validation for recipient parameter"
Skipped Comments (1)
-
app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/PendingActionHelper.kt [21-21]
performance: "Use asynchronous SharedPreferences operation for better performance"
lmcmz
approved these changes
Apr 24, 2025
lmcmz
previously approved these changes
Apr 24, 2025
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (3)
Files Processed (10)
- app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/DeepLinkingActivity.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/PendingActionHelper.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/Utils.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/main/MainActivity.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/send/transaction/subpage/amount/SendAmountActivity.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/send/transaction/subpage/amount/SendAmountViewModel.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/send/transaction/subpage/amount/presenter/SendAmountPresenter.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/widgets/SwitchNetworkDialog.kt (3 hunks)
- app/src/main/res/values/strings.xml (1 hunk)
- gradle.properties (1 hunk)
Actionable Comments (0)
Skipped Comments (3)
-
app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/Utils.kt [148-148]
best practice: "Add error handling for invalid recipient addresses"
-
app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/PendingActionHelper.kt [18-23]
performance: "Use asynchronous SharedPreferences writes"
-
app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/Utils.kt [122-135]
possible issue: "Add decimal precision validation in value parsing"
lmcmz
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #827
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)