Skip to content

fix: wallet notification null point time#868

Merged
jaymengxy merged 1 commit intodevelopfrom
fix_wallet_notification_view
Apr 24, 2025
Merged

fix: wallet notification null point time#868
jaymengxy merged 1 commit intodevelopfrom
fix_wallet_notification_view

Conversation

@jaymengxy
Copy link
Copy Markdown
Contributor

Related Issue

Closes #276

Summary of Changes

Need Regression Testing

  • Yes
  • No

Risk Assessment

  • Low
  • Medium
  • High

Additional Notes

Screenshots (if applicable)

@jaymengxy jaymengxy added this to the Release 2.8.3 milestone Apr 24, 2025
@jaymengxy jaymengxy self-assigned this Apr 24, 2025
@jaymengxy jaymengxy requested a review from a team as a code owner April 24, 2025 09:48
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 24, 2025

PR Summary

Updated the WalletNotification model to handle nullable expiry time values, preventing potential null pointer exceptions. Modified the isExpired() function to safely handle null expiry times by using the Kotlin safe call operator and Elvis operator, returning false when expiry time is null.

Changes

File Summary
app/src/main/java/com/flowfoundation/wallet/page/notification/model/WalletNotification.kt Changed expiryTime field to be nullable (Date?) and updated isExpired() function to safely handle null values using ?.let with Elvis operator, returning false when expiryTime is null.

autogenerated by presubmit.ai

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (1)
  • 167c602: fix: wallet notification null point time
Files Processed (1)
  • app/src/main/java/com/flowfoundation/wallet/page/notification/model/WalletNotification.kt (2 hunks)
Actionable Comments (0)
Skipped Comments (2)
  • app/src/main/java/com/flowfoundation/wallet/page/notification/model/WalletNotification.kt [28-28]

    best practice: "Missing default value for nullable property"

  • app/src/main/java/com/flowfoundation/wallet/page/notification/model/WalletNotification.kt [45-45]

    readability: "Improve readability of null-safe expression"

@jaymengxy jaymengxy merged commit 34a8992 into develop Apr 24, 2025
3 checks passed
@jaymengxy jaymengxy deleted the fix_wallet_notification_view branch April 24, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

android.view.InflateException: Binary XML file line #52: Binary XML file line #52: Error...

2 participants