fix: wallet notification null point time#868
Merged
Conversation
PR SummaryUpdated the WalletNotification model to handle nullable expiry time values, preventing potential null pointer exceptions. Modified the isExpired() function to safely handle null expiry times by using the Kotlin safe call operator and Elvis operator, returning false when expiry time is null. Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 167c602: fix: wallet notification null point time
Files Processed (1)
- app/src/main/java/com/flowfoundation/wallet/page/notification/model/WalletNotification.kt (2 hunks)
Actionable Comments (0)
Skipped Comments (2)
-
app/src/main/java/com/flowfoundation/wallet/page/notification/model/WalletNotification.kt [28-28]
best practice: "Missing default value for nullable property"
-
app/src/main/java/com/flowfoundation/wallet/page/notification/model/WalletNotification.kt [45-45]
readability: "Improve readability of null-safe expression"
lmcmz
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #276
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)