Skip to content

Conversation

@zhouxl
Copy link
Collaborator

@zhouxl zhouxl commented Apr 24, 2025

Related Issue

Summary of Changes

fix actualBalance is nil when initializing the attributes

Need Regression Testing

  • Yes
  • No

Risk Assessment

  • Low
  • Medium
  • High

Additional Notes

Screenshots (if applicable)

@zhouxl zhouxl requested a review from a team as a code owner April 24, 2025 12:56
@zhouxl zhouxl added this to the Release 2.4.5 milestone Apr 24, 2025
@github-actions
Copy link

github-actions bot commented Apr 24, 2025

PR Summary

Added initialization of actualBalance property when a predefined amount is provided through deeplink. Previously, the actualBalance was not being set during initialization when an amount was passed, which could lead to nil value issues. The fix ensures the amount is properly formatted according to the token's decimal places.

Changes

File Summary
FRW/Modules/Wallet/Send/WalletSendAmountViewModel.swift Added initialization of actualBalance using the provided amount value in the view model's initializer. The amount is formatted as currency string using the token's decimal places.

autogenerated by presubmit.ai

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (1)
  • 9319935: feat: actualBalance from deeplink
Files Processed (1)
  • FRW/Modules/Wallet/Send/WalletSendAmountViewModel.swift (1 hunk)
Actionable Comments (0)
Skipped Comments (1)
  • FRW/Modules/Wallet/Send/WalletSendAmountViewModel.swift [59-59]

    possible issue: "Potential number formatting issue when handling decimal values"

@zhouxl zhouxl merged commit 8a5d0f9 into main Apr 24, 2025
3 checks passed
@zhouxl zhouxl deleted the release/245-fix-amount branch April 24, 2025 13:00
This was referenced Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants