Release 2.4.9 #1402
Merged
Release 2.4.9 #1402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…webpage WalletManager refactor
# Conflicts: # FRW.xcodeproj/project.pbxproj # FRW/Services/Manager/WalletManager.swift
Merge/from main
Fix/xcode build error
Add dev tag for dev app
… to flow (#1283) * feat: ChildAccountManager.shared.selectedChildAccount -> WalletManager.shared.selectedChildAccount EVMAccountManager.shared.selectedAccount -> WalletManager.shared.selectedEVMAccount * feat: Syntax error * fix: NFT Add Collection only show when is mainaccount
Fix timeout
…#1300) * feat: Modify one place and all versions of the target will be updated * feat: update version to 2.4.7
format balance of display
* feat: #1319 update struct for stake delegator info * feat: udpate version to 2.4.8 * feat: update stake delegateId
* feat: format all balance * feat: format wallet price
…rewards Fix staking issue
…wallet-for-ai-sports-rebooted-and-still-doesnt-work Fix optional chains is ignore when check chainID
…n-token-detail-page-when-its-evm-account Only show storage info under flow account
…nt-not-shown-on-ios Fix child account no image issue
PR SummaryRefactored wallet management system with new account handling, updated project dependencies, and removed legacy domain claim functionality. Added dependency injection container and improved error handling. Changes
autogenerated by presubmit.ai |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (30)
- 67942f9: Add blur cover
- 2484f39: Update flow wallet kit import
- 1304ee0: Fix account creation
- 0e8b575: Merge pull request #1208 from onflow/add-DEV-ICON
Add dev tag for dev app
- 6273c2b: Add dev tag for dev app
- 15ad596: Merge pull request #1206 from onflow/fix/xcode-build-error
Fix/xcode build error
- d3e1bb3: feat: remove localUserDefault key flownetwork
- 0c3592f: feat: update for new manager
- 81d0765: Merge pull request #1196 from onflow/merge/from-main
Merge/from main
Conflicts:
FRW.xcodeproj/project.pbxproj
FRW/Services/Manager/WalletManager.swift
WalletManager refactor
- 34e1cdb: Remove unused func
- d50dbb2: Use local wallet kit for temp
- 7523b5d: Merge remote-tracking branch 'origin' into 124-bug-unable-to-interact-with-webpage
- 9874939: Fix build error
- 518b737: Remove flow network with flow.chainId
- 00cd0e3: Update cloudfunctions.json
- 3cf7394: Fix build error
- ffad1ee: Merge remote-tracking branch 'origin' into 124-bug-unable-to-interact-with-webpage
- bb52599: rename currentMainAccount to mainAccount
- 80fe616: Merge remote-tracking branch 'origin' into 124-bug-unable-to-interact-with-webpage
- 82fa178: Fix build error
- 123b3fe: Fix incorrect signer issue
- 7188410: Add DI
- 10fd80e: Simplify logic
- 64b2308: Code cleanup
- 840b356: Simplify wallet manager logic
- 1218018: Add selectedAccount and currentAccount
- 606e7d9: WalletManager refactor
Files Processed (30)
- FRW.xcodeproj/project.pbxproj (0 hunks)
- FRW.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved (15 hunks)
- FRW/App/AppDelegate.swift (6 hunks)
- FRW/App/Container.swift (1 hunk)
- FRW/App/Env/Prod/Info.plist (1 hunk)
- FRW/App/Env/ServiceConfig.swift (1 hunk)
- FRW/Foundation/Base/FlowLog.swift (1 hunk)
- FRW/Foundation/BridgeFeePayer.swift (1 hunk)
- FRW/Foundation/Model/Error.swift (5 hunks)
- FRW/Foundation/Model/FWAccount.swift (1 hunk)
- FRW/Foundation/Model/FWAddress.swift (2 hunks)
- FRW/Foundation/Model/FlowNetworkType.swift (1 hunk)
- FRW/Foundation/Model/TokenModelResponse.swift (1 hunk)
- FRW/Foundation/Model/WalletModels.swift (5 hunks)
- FRW/Modules/Backup/BackupPasswordView.swift (1 hunk)
- FRW/Modules/Backup/ManualBackupView.swift (1 hunk)
- FRW/Modules/Backup/RecoveryPhraseView.swift (1 hunk)
- FRW/Modules/BlockList/BlocklistHandler.swift (1 hunk)
- FRW/Modules/Browser/Bookmark/BrowserBookmarkView.swift (1 hunk)
- FRW/Modules/Browser/BrowserViewController+JS.swift (2 hunks)
- FRW/Modules/Browser/DApps/DAppsListView.swift (2 hunks)
- FRW/Modules/Browser/Handler/JSMessageHandler.swift (1 hunk)
- FRW/Modules/Browser/Model/FCLScripts.swift (2 hunks)
- FRW/Modules/Browser/Model/JSModels.swift (1 hunk)
- FRW/Modules/Browser/View/BrowserAuthzViewModel.swift (1 hunk)
- FRW/Modules/Browser/View/NetworkSwitchPopView.swift (3 hunks)
- FRW/Modules/Buy/BuyProvderView.swift (1 hunk)
- FRW/Modules/Domain/ClaimDomainView.swift (1 hunk)
- FRW/Modules/Domain/ClaimDomainViewModel.swift (1 hunk)
- FRW/Modules/EVM/View/EVMEnableView.swift (1 hunk)
Actionable Comments (1)
-
FRW/Foundation/Model/Error.swift [74-86]
typo: "Fix typos in error case names"
Skipped Comments (3)
-
FRW/Foundation/Model/FWAccount.swift [67-69]
best practice: "Improve error handling for address creation failure"
-
FRW/App/Container.swift [13-16]
best practice: "Avoid singleton in dependency injection container"
-
FRW/Modules/Browser/Handler/JSMessageHandler.swift [217-221]
enhancement: "Improve log message formatting"
Comment on lines
74
to
86
| case securityVerifyFailed | ||
| case collectionIsNil | ||
| case noPrimaryWalletAddress | ||
| case emptyKeyProvider | ||
| case emptyAccountKey | ||
| case invalidMnemonic | ||
| case invaildPublicKey | ||
| case invaildAddress | ||
| case fetchLinkedAccountsFailed | ||
| case emptyAddress | ||
| case emptyScript | ||
| case emptyMainAccount | ||
| case emptyTransaction |
There was a problem hiding this comment.
There are typos in several error case names: 'invaildMnemonic', 'invaildPublicKey', 'invaildAddress' should be 'invalidMnemonic', 'invalidPublicKey', 'invalidAddress' respectively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Close #1401
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)