Fix some minor issues found by automated code review tool#123
Merged
jordanschalm merged 2 commits intomainfrom Jan 27, 2026
Merged
Fix some minor issues found by automated code review tool#123jordanschalm merged 2 commits intomainfrom
jordanschalm merged 2 commits intomainfrom
Conversation
Member
jordanschalm
commented
Jan 27, 2026
jordanschalm
commented
- consistent function access control for recording deposit/withdrawal
- mark unused version field deprecated
turbolent
approved these changes
Jan 27, 2026
turbolent
reviewed
Jan 27, 2026
Member
turbolent
left a comment
turbolent
left a comment
There was a problem hiding this comment.
As noted in the Q&A, we can actually assume a redeployment and should maybe just remove the field. Alternatively we could have a separate pass after an update to remove all deprecated fields
Member
Author
There are quite a few, so I will go through and remove them all together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.