Kan/happy path test improvement#17
Merged
Kay-Zee merged 2 commits intocadence-testing-patterns-forkfrom Jun 19, 2025
Merged
Conversation
kgrgpg
reviewed
Jun 19, 2025
Contributor
There was a problem hiding this comment.
Great work discovering that withdrawAndPull with pullFromTopUpSource: true actually works to return collateral!
The solution is elegant - using the PositionWrapper's authorization to enable the withdraw operation is exactly how the protocol was designed to work.
I noticed the comments and logs still say collateral cannot be withdrawn, which is now incorrect. Here are some suggested updates to reflect what's actually happening:
For repay_and_close_position.cdc:
- Update the header comment to explain that this transaction DOES return collateral
- Change the misleading log messages at the end
For position_lifecycle_happy_test.cdc:
- Add a log showing Flow balance before repayment (should be 0)
- Update the final log message to celebrate that collateral was successfully returned
I've tested these changes locally and the test passes with the updated logs showing:
Flow balance BEFORE repay: 0.00000000
...
SUCCESS: Position closed successfully!
Debt repaid and collateral returned to user
Flow balance after repay: 1000.00000000 - Collateral successfully returned!
kgrgpg
added a commit
that referenced
this pull request
Jun 19, 2025
- Merged PR #17 which provides a clean solution for collateral withdrawal - Uses MockTidalProtocolConsumer.borrowPositionForWithdraw() to provide FungibleToken.Withdraw authorization - withdrawAndPull with pullFromTopUpSource: true automatically repays debt and returns collateral - Updated misleading comments and logs to reflect that collateral IS successfully returned - This approach avoids the security vulnerability in PR #16's repayAndClosePosition method
This was referenced Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.