Kan/fix available balance calculation#18
Merged
kgrgpg merged 2 commits intocadence-testing-patterns-forkfrom Jun 20, 2025
Merged
Kan/fix available balance calculation#18kgrgpg merged 2 commits intocadence-testing-patterns-forkfrom
kgrgpg merged 2 commits intocadence-testing-patterns-forkfrom
Conversation
…ase where we're pulling directly from the collateral
Kay-Zee
commented
Jun 19, 2025
| let availableEffectiveValue = availableHealth * effectiveDebtAfterDeposit | ||
|
|
||
| // If there is no debt, then we can just use the entire collateral amount | ||
| let availableEffectiveValue = effectiveDebtAfterDeposit == 0.0 ? effectiveCollateralAfterDeposit : availableHealth * effectiveDebtAfterDeposit |
Member
Author
There was a problem hiding this comment.
currently just using effectiveCollateralAfterDeposit for the case where effectiveDebtAfterDeposit is 0.0, due to this causing issues with the equation if we actually use 0 in the equation below.
kgrgpg
added a commit
that referenced
this pull request
Jun 20, 2025
- Tests that when a position has no debt, availableBalance() returns full collateral amount - Regression test for the bug where zero debt positions couldn't withdraw (availableBalance returned 0) - Verifies the conditional logic: when effectiveDebtAfterDeposit == 0.0, use effectiveCollateralAfterDeposit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This handles the case where the effective debt is zero (i.e. we can pay off the entire debt), therefore the entire collateral should be available for withrdaw