Skip to content

Add documentation to FlowALPHealth and make interest index params optional#185

Merged
liobrasil merged 1 commit intoliob/split-v0-health-position-resourcesfrom
jord/health-docs-optional-index
Mar 6, 2026
Merged

Add documentation to FlowALPHealth and make interest index params optional#185
liobrasil merged 1 commit intoliob/split-v0-health-position-resourcesfrom
jord/health-docs-optional-index

Conversation

@jordanschalm
Copy link
Member

Add doc comments to all four public functions in FlowALPHealth. Change interest index parameters (withdrawCreditInterestIndex, depositDebitInterestIndex) to optional types, passing nil when the balance direction doesn't match instead of a dummy 1.0 value. (We should never use the 1.0 value: using a nil optional instead makes it so that we will panic if we ever execute that unexpected path.)

…ional

Add doc comments to all four public functions in FlowALPHealth following
the positionSatisfiesMinimumBalance doc style. Change interest index
parameters (withdrawCreditInterestIndex, depositDebitInterestIndex) to
optional types, passing nil when the balance direction doesn't match
instead of a dummy 1.0 value.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Contributor

@liobrasil liobrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liobrasil liobrasil merged commit cf3480c into liob/split-v0-health-position-resources Mar 6, 2026
@liobrasil liobrasil deleted the jord/health-docs-optional-index branch March 6, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants