Skip to content

FLO-1: Uncollected Protocol Fees Are Permanently Lost when Reserves Are Low#273

Merged
UlyanaAndrukhiv merged 15 commits intomainfrom
UlianaAndrukhiv/210-uncollected-protocol-fees-fix
Mar 19, 2026
Merged

FLO-1: Uncollected Protocol Fees Are Permanently Lost when Reserves Are Low#273
UlyanaAndrukhiv merged 15 commits intomainfrom
UlianaAndrukhiv/210-uncollected-protocol-fees-fix

Conversation

@UlyanaAndrukhiv
Copy link
Contributor

@UlyanaAndrukhiv UlyanaAndrukhiv commented Mar 17, 2026

Closes: #210

Context

This PR fixes a protocol accounting issue where insurance and stability fees could be permanently lost when reserves were insufficient during fee collection.

Our solution is to skip fee collection until there are sufficient reserves to cover the full amount, preventing partial withdrawals and preserving the correct accounting.

Changes:

@UlyanaAndrukhiv UlyanaAndrukhiv self-assigned this Mar 17, 2026
@UlyanaAndrukhiv UlyanaAndrukhiv marked this pull request as ready for review March 17, 2026 15:14
@UlyanaAndrukhiv UlyanaAndrukhiv requested a review from a team as a code owner March 17, 2026 15:14
Copy link
Member

@jordanschalm jordanschalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few nitpicks

@UlyanaAndrukhiv UlyanaAndrukhiv requested a review from a team March 18, 2026 11:36
@UlyanaAndrukhiv UlyanaAndrukhiv merged commit 3550821 into main Mar 19, 2026
1 check passed
@UlyanaAndrukhiv UlyanaAndrukhiv deleted the UlianaAndrukhiv/210-uncollected-protocol-fees-fix branch March 19, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FLO-1: Uncollected Protocol Fees Are Permanently Lost when Reserves Are Low

3 participants