Merged
Conversation
nialexsan
force-pushed
the
nialexsan/refactor-fund-available-rebased
branch
from
020382f to
3c3c06b
Compare
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
|
@nialexsan #27 and #28 look to include similar changes. Should they be stacked or should one of them be closed? |
Contributor
Author
|
@sisyphusSmiling yep, sorry, forgot to close the other one, after rebasing and trimming down all the changes |
Contributor
Author
|
the only difference is in this snippet: |
Comment on lines
+360
to
+368
| access(all) struct AdjustedBalances { | ||
| access(all) let collateral: UInt256 | ||
| access(all) let debt: UInt256 | ||
|
|
||
| init (collateral: UInt256, debt: UInt256) { | ||
| self.collateral = collateral | ||
| self.debt = debt | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Could we just use the BalanceSheet struct instead of creating a new object?
nialexsan
commented
Jul 17, 2025
Merged
* replace DeFiBlocks with DeFiActions submodule * update all DeFiBlocks (DFB) references to DeFiActions (DFA)
sisyphusSmiling
approved these changes
Jul 18, 2025
Co-authored-by: Giovanni Sanchez <108043524+sisyphusSmiling@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactored functions