Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
nialexsan
commented
Aug 21, 2025
| self.lastUpdate = currentTime | ||
|
|
||
| // Update deposit capacity based on time | ||
| let newDepositCapacity = self.depositCapacity + (self.depositRate * timeDelta) |
Contributor
Author
There was a problem hiding this comment.
this calculation causes overflow if time delta is big
sisyphusSmiling
approved these changes
Sep 5, 2025
Comment on lines
+344
to
+347
| if remaining <= 0.0 { | ||
| self.depositCapacity = self.depositCapacityCap | ||
| return | ||
| } |
Contributor
There was a problem hiding this comment.
We should never hit this block due to the conditional at L334, I think it's safe to remove
Comment on lines
+356
to
+358
| // Safe: growth <= remaining, so the addition cannot overflow | ||
| let growth: UFix64 = effectiveRate * dt | ||
| self.depositCapacity = self.depositCapacity + growth |
Contributor
There was a problem hiding this comment.
If we're worried about overflow on addition here, we could do something like
if growth <= self.depositCapacityCap && self.depositCapacity < (self.depositCapacityCap - growth) {
self.depositCapacity = self.depositCapacity + growth
} else {
self.depositCapacity = self.depositCapacityCap
}But I'm taking your comment here to mean overflow was an issue on multiplication
Contributor
Author
There was a problem hiding this comment.
growth should be always less than depositCapacityCap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.