Panic when maxAmount exceeded in IncrementFiStakingConnectors#155
Merged
Kay-Zee merged 1 commit intokan/fix-lint-issuesfrom Mar 21, 2026
Merged
Panic when maxAmount exceeded in IncrementFiStakingConnectors#155Kay-Zee merged 1 commit intokan/fix-lint-issuesfrom
maxAmount exceeded in IncrementFiStakingConnectors#155Kay-Zee merged 1 commit intokan/fix-lint-issuesfrom
Conversation
Kay-Zee
approved these changes
Mar 21, 2026
nvdtf
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue uncovered by
flow cadence lintwhere themaxAmountpassed toIncrementFiStakingConnectors.Sinkwas less than the amount returned by the staking pool (see #154).Adding an assertion ensures that the
maxAmountvalue is respected and that the caller will not receive more tokens than they are able to handle