Skip to content

Bump Go and linter versions and update the code#582

Merged
fxamacker merged 8 commits intomainfrom
fxamacker/bump-go-version-to-1.24
Oct 14, 2025
Merged

Bump Go and linter versions and update the code#582
fxamacker merged 8 commits intomainfrom
fxamacker/bump-go-version-to-1.24

Conversation

@fxamacker
Copy link
Member

@fxamacker fxamacker commented Oct 9, 2025

This PR bumps Go from 1.23 to 1.24.

  • ci.yml
  • go.mod
  • update golangci-lint.yml
  • update Go code for 1.24

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@fxamacker fxamacker self-assigned this Oct 9, 2025
@fxamacker fxamacker requested a review from turbolent as a code owner October 9, 2025 15:48
@fxamacker fxamacker added the CI CI and GitHub Actions Workflows label Oct 9, 2025
@fxamacker fxamacker changed the title Bump Go version to 1.24 WIP: Bump Go version to 1.24 Oct 9, 2025
While at it, migrate the configuration and
also enable the revive linter.
Go 1.21 introduced min and max, so rename those to something else.
We should avoid using "_" in package names and
this is now detected by the revive linter.
This commit removed embedded field "elements" from selector "MapDataSlab".

This cosmetic issue is detected by the staticcheck linter.

There is no change to mainnet and testnet behavior by fixing this
cosmetic issue.
@fxamacker fxamacker changed the title WIP: Bump Go version to 1.24 Bump Go and linter versions and update the code Oct 10, 2025
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@fxamacker fxamacker merged commit 41e3237 into main Oct 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI CI and GitHub Actions Workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants