Change slab size related variables from uint64 to uint32#586
Merged
Conversation
Currently, some slab size related variables, such as targetThreshold, minThreshold, maxThreshold, are uint64. However, ArraySlabHeader.size and MapSlabHeader.size are uint32. This causes frequent type casting when comparing slab size with target slab size. This commit refactors slab size related variables to use uint32 to simplify code and be explicit about the supported max slab size (math.MaxUint32). This commit also modifies some exported function return types to be consistent.
fxamacker
added
improvement
api breaking change
Member
|
Nice! Is this only a breaking change in the API, or is it also a breaking change for the stored data? |
Member
Author
@turbolent This is only API breaking change. No changes to the stored data. |
Member
Author
|
I renamed "breaking change" label to "api breaking change". We also have "storage breaking change" as a separate label. |
turbolent
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we use frequent type casting when comparing slab size with target slab size, because
some slab size related variables, such as
targetThreshold,minThreshold,maxThreshold, areuint64, butArraySlabHeader.sizeandMapSlabHeader.sizeareuint32.This PR refactors slab size related variables to use
uint32to simplify code and be explicit about the supported max slab size (math.MaxUint32).This PR also modifies some exported function parameters and return types to be consistent with the changes. So client software needs to modify code calling the updated functions.
mainbranchFiles changedin the Github PR explorer