Filter fee events

[bthaile]

Closes: #1151

Description

• filter out "FeeEvent" and "FlowToken" events by default.
• Add new included fee-events flag so users can get all events including the fee events.
• Added two new tests to test filtering events
• Updated transactions get command include flags help

---

For contributor use:

• Targeted PR against master branch
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work
• Code follows the standards mentioned here
• Updated relevant documentation
• Re-reviewed Files changed in the Github PR explorer
• Added appropriate labels

[codecov-commenter]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.25% 🎉

Comparison is base (3148a57) 38.40% compared to head (aecdb6c) 38.65%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1188      +/-   ##
==========================================
+ Coverage   38.40%   38.65%   +0.25%     
==========================================
  Files          38       38              
  Lines        1940     1948       +8     
==========================================
+ Hits          745      753       +8     
  Misses       1107     1107              
  Partials       88       88              

Flag	Coverage Δ
unittests	38.65% <100.00%> (+0.25%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
internal/transactions/get.go	81.81% <ø> (ø)
internal/transactions/transactions.go	62.74% <100.00%> (+3.17%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bjartek]

Will this not remove all FlowToken events?
The fee events are always the 3 latest in a tx. Just remove them?
So the withdraw/deposit/fee
I think fee and effort should be returned in TransactionResult personally. Those 3 events are different the the others cause you did not emit them. The system did.

[bthaile]

Will this not remove all FlowToken events? The fee events are always the 3 latest in a tx. Just remove them? So the withdraw/deposit/fee I think fee and effort should be returned in TransactionResult personally. Those 3 events are different the the others cause you did not emit them. The system did.

I was going off the github issue linked. Spot checking some transactions, I see what you are saying the last three events are what need to be filtered out. I'll update the PR.
Thanks

[janezpodhostnik]

In certain setups (fees are set to 0) there will be no fee events. I would make the check more complex:

If a FeesDeducted event is present (should be the last one) then the last 3 events are fee events.

[chasefleming]

@bthaile Can we make sure we update the docs wherever necessary with this new flag?

[bthaile]

@bthaile Can we make sure we update the docs wherever necessary with this new flag?

Updated here, internal/transactions/get.go in the PR. Are their other docs?

good call, I can update developer docs, here https://developers.flow.com/tools/flow-cli/transactions/get-transactions

created docs github issue
onflow/docs#358

[chasefleming]

Thanks @bthaile !