Skip to content

Update hybrid-custody-scaffold commit hash#1235

Merged
chasefleming merged 1 commit into
masterfrom
update-hybrid-custody-scaffold
Oct 18, 2023
Merged

Update hybrid-custody-scaffold commit hash#1235
chasefleming merged 1 commit into
masterfrom
update-hybrid-custody-scaffold

Conversation

@sisyphusSmiling

@sisyphusSmiling sisyphusSmiling commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

Closes #1234

Relevant PR: onflow/hybrid-custody-scaffold#6


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sisyphusSmiling sisyphusSmiling added the Improvement Technical work without new features, refactoring, improving tests label Oct 18, 2023
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (16b0c27) 38.65% compared to head (70f24e5) 38.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1235   +/-   ##
=======================================
  Coverage   38.65%   38.65%           
=======================================
  Files          38       38           
  Lines        1948     1948           
=======================================
  Hits          753      753           
  Misses       1107     1107           
  Partials       88       88           
Flag Coverage Δ
unittests 38.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chasefleming chasefleming merged commit 9b23ccf into master Oct 18, 2023
@chasefleming chasefleming deleted the update-hybrid-custody-scaffold branch October 18, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Technical work without new features, refactoring, improving tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hybrid Custody scaffold has outdated deployment info

3 participants