Skip to content

Add FLIX v1.1 Support#1309

Merged
bthaile merged 7 commits into
masterfrom
update-flix-v1.1
Dec 19, 2023
Merged

Add FLIX v1.1 Support#1309
bthaile merged 7 commits into
masterfrom
update-flix-v1.1

Conversation

@bthaile

@bthaile bthaile commented Dec 14, 2023

Copy link
Copy Markdown
Contributor

Simplify how flixkit-go is used and integrated into flow-cli

Description

Update to support

Update flix execute command to support both v1.0 and v1.1 🚗
Update flix generate command to generate v1.1 format 🧑‍🍳
Update flix package to support v1.0 and v1.1 and produce TypeScript binding files 🌐


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@bthaile bthaile marked this pull request as draft December 14, 2023 21:06
@bthaile bthaile changed the title integrate flix v1.1 execute, generate and package, add support for pa… integrate flix v1.1 Dec 14, 2023
@bthaile bthaile marked this pull request as ready for review December 18, 2023 20:28
@codecov-commenter

codecov-commenter commented Dec 18, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 53 lines in your changes are missing coverage. Please review.

Comparison is base (d910d27) 39.93% compared to head (05a91c6) 40.74%.
Report is 7 commits behind head on master.

Files Patch % Lines
internal/super/flix.go 0.00% 53 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1309      +/-   ##
==========================================
+ Coverage   39.93%   40.74%   +0.81%     
==========================================
  Files          39       39              
  Lines        2161     2118      -43     
==========================================
  Hits          863      863              
+ Misses       1203     1160      -43     
  Partials       95       95              
Flag Coverage Δ
unittests 40.74% <0.00%> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chasefleming

Copy link
Copy Markdown
Member

Can you add the right label and make the title a little more descriptive please? Helps with release notes.

@bthaile bthaile changed the title integrate flix v1.1 Add FLIX v1.1 Support Dec 19, 2023
@bthaile bthaile added the Feature A new user feature or a new package API label Dec 19, 2023
@bthaile

bthaile commented Dec 19, 2023

Copy link
Copy Markdown
Contributor Author

Can you add the right label and make the title a little more descriptive please? Helps with release notes.

Doh!! updated PR to be more descriptive with emojis

@chasefleming

Copy link
Copy Markdown
Member

Lol thanks

@bthaile bthaile merged commit 8c9c6a8 into master Dec 19, 2023
@bthaile bthaile deleted the update-flix-v1.1 branch December 19, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature A new user feature or a new package API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants