Skip to content

Fix staging validator type change bug#1495

Merged
jribbink merged 2 commits into
feature/stable-cadencefrom
jribbink/validator-bug
Apr 5, 2024
Merged

Fix staging validator type change bug#1495
jribbink merged 2 commits into
feature/stable-cadencefrom
jribbink/validator-bug

Conversation

@jribbink

@jribbink jribbink commented Apr 5, 2024

Copy link
Copy Markdown
Contributor

Description

Patch for missing type change handler, needed for NFT migrations/other custom type change rules.

Will make a follow up to export this from flow-go & use this, but this is a stop-gap.

https://discord.com/channels/613813861610684416/621847426201944074/1225634870730948689


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink changed the base branch from master to feature/stable-cadence April 5, 2024 05:24
@codecov-commenter

codecov-commenter commented Apr 5, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 42.04%. Comparing base (5c0fa11) to head (e888b63).

Files Patch % Lines
internal/migrate/staging_validator.go 53.33% 5 Missing and 2 partials ⚠️
internal/migrate/stage_contract.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/stable-cadence    #1495      +/-   ##
==========================================================
+ Coverage                   41.99%   42.04%   +0.05%     
==========================================================
  Files                          59       59              
  Lines                        3360     3375      +15     
==========================================================
+ Hits                         1411     1419       +8     
- Misses                       1745     1750       +5     
- Partials                      204      206       +2     
Flag Coverage Δ
unittests 42.04% <50.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jribbink jribbink added the Bug The issue represents a bug, malfunction, regression label Apr 5, 2024
@jribbink jribbink merged commit 050b039 into feature/stable-cadence Apr 5, 2024
@jribbink jribbink deleted the jribbink/validator-bug branch April 5, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug The issue represents a bug, malfunction, regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants