Skip to content

QA: Adjust JSON camelCase output #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
devbugging merged 1 commit into from
Apr 7, 2021
Merged

QA: Adjust JSON camelCase output #155

devbugging merged 1 commit into from
Apr 7, 2021

Conversation

@psiemens
Copy link
Contributor

@psiemens psiemens commented Apr 7, 2021

Description

  • Noticed that staking info still had capitalized JSON output
  • Opted use Id instead of ID -- I think it's a bit more JSONish
  • Changed transaction Hash to ID, since that's what we say in our docs

@psiemens psiemens requested a review from devbugging April 7, 2021 06:15
@psiemens psiemens changed the title Adjust JSON camelCase output QA: Adjust JSON camelCase output Apr 7, 2021
@devbugging devbugging merged commit 2ecfe06 into feature/sharedlib Apr 7, 2021
@devbugging devbugging deleted the sharedlib-json-camelcase branch April 7, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devbugging devbugging Awaiting requested review from devbugging

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik

@Kay-Zee Kay-Zee Awaiting requested review from Kay-Zee

@turbolent turbolent Awaiting requested review from turbolent

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@psiemens @devbugging