Upgrade flowkit to v1.18.0#1594
Merged
Merged
Conversation
chasefleming
requested review from
Kay-Zee,
bjartek,
bluesign,
devbugging,
ianthpun,
janezpodhostnik,
jribbink and
nvdtf
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1594 +/- ##
=======================================
Coverage 39.35% 39.35%
=======================================
Files 51 51
Lines 3326 3326
=======================================
Hits 1309 1309
Misses 1850 1850
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jribbink
reviewed
May 14, 2024
| } | ||
|
|
||
| state, err := flowkit.Init(readerWriter, sigAlgo, hashAlgo) | ||
| state, err := flowkit.Init(readerWriter) |
Contributor
There was a problem hiding this comment.
I think this is a case where we should have the emulator account
jribbink
approved these changes
May 14, 2024
jribbink
left a comment
jribbink
left a comment
Contributor
There was a problem hiding this comment.
Feel free to merge after adding the emulator account back for flow config init
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For contributor use:
masterbranchFiles changedin the Github PR explorer