Skip to content

Only ask for deployments and aliases once#1598

Merged
chasefleming merged 7 commits into
masterfrom
chasefleming/ask-once
May 15, 2024
Merged

Only ask for deployments and aliases once#1598
chasefleming merged 7 commits into
masterfrom
chasefleming/ask-once

Conversation

@chasefleming

@chasefleming chasefleming commented May 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #1569

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@chasefleming chasefleming marked this pull request as ready for review May 15, 2024 17:54
@chasefleming chasefleming added the Bug The issue represents a bug, malfunction, regression label May 15, 2024
ianthpun
ianthpun reviewed May 15, 2024
View reviewed changes
Comment thread internal/dependencymanager/dependencyinstaller.go Outdated
@chasefleming chasefleming requested a review from ianthpun May 15, 2024 18:02
@codecov-commenter

codecov-commenter commented May 15, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.97561% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/dependencymanager/dependencyinstaller.go 60.97% 13 Missing and 3 partials ⚠️

📢 Thoughts on this report? Let us know!

@chasefleming chasefleming merged commit 9d33723 into master May 15, 2024
@chasefleming chasefleming deleted the chasefleming/ask-once branch May 15, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jribbink jribbink jribbink approved these changes
@Kay-Zee Kay-Zee Awaiting requested review from Kay-Zee Kay-Zee is a code owner
@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik is a code owner
@devbugging devbugging Awaiting requested review from devbugging
@nvdtf nvdtf Awaiting requested review from nvdtf nvdtf is a code owner
@bluesign bluesign Awaiting requested review from bluesign
@bjartek bjartek Awaiting requested review from bjartek bjartek is a code owner
+1 more reviewer
@ianthpun ianthpun ianthpun approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug The issue represents a bug, malfunction, regression

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Dependency Manager repeats the inquiry for extra dependencies

4 participants

@chasefleming @codecov-commenter @ianthpun @jribbink