Skip to content

QA wrong flag value #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
devbugging merged 1 commit into from
Apr 7, 2021
Merged

QA wrong flag value #160

devbugging merged 1 commit into from
Apr 7, 2021

Conversation

@devbugging
Copy link
Contributor

@devbugging devbugging commented Apr 7, 2021

Description

Args flag had wrong default value causing warning to be shown everytime

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@devbugging devbugging requested a review from psiemens April 7, 2021 13:31
@devbugging devbugging self-assigned this Apr 7, 2021
@psiemens psiemens changed the base branch from master to feature/sharedlib April 7, 2021 15:05
@devbugging devbugging merged commit afee309 into feature/sharedlib Apr 7, 2021
@devbugging devbugging deleted the sharedlib-qa-flag branch April 7, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik

@Kay-Zee Kay-Zee Awaiting requested review from Kay-Zee

@turbolent turbolent Awaiting requested review from turbolent

1 more reviewer

@psiemens psiemens psiemens approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@devbugging devbugging

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devbugging @psiemens