Skip to content

Handle transaction result errors in flow migrate stage#1607

Merged
jribbink merged 1 commit into
feature/stable-cadencefrom
jribbink/staging-errors
May 17, 2024
Merged

Handle transaction result errors in flow migrate stage#1607
jribbink merged 1 commit into
feature/stable-cadencefrom
jribbink/staging-errors

Conversation

@jribbink

Copy link
Copy Markdown
Contributor

Description

Errors while staging a contract (related to a failed transaction) are not properly reported. This handles that case.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink added the Improvement Technical work without new features, refactoring, improving tests label May 17, 2024
@jribbink jribbink changed the title Handle transaction result errors in flow stage Handle transaction result errors in flow migrate stage May 17, 2024
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.17%. Comparing base (ad513f5) to head (401fb13).

Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/stable-cadence    #1607      +/-   ##
==========================================================
+ Coverage                   42.02%   42.17%   +0.14%     
==========================================================
  Files                          60       60              
  Lines                        4200     4202       +2     
==========================================================
+ Hits                         1765     1772       +7     
+ Misses                       2200     2197       -3     
+ Partials                      235      233       -2     
Flag Coverage Δ
unittests 42.17% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jribbink jribbink merged commit 1bb8459 into feature/stable-cadence May 17, 2024
@jribbink jribbink deleted the jribbink/staging-errors branch May 17, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Technical work without new features, refactoring, improving tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants