Skip to content

Update to Cadence v1.0.0-preview.30#1631

Merged
turbolent merged 8 commits into
feature/stable-cadencefrom
auto-update-onflow-cadence-v1.0.0-preview.30
Jun 3, 2024
Merged

Update to Cadence v1.0.0-preview.30#1631
turbolent merged 8 commits into
feature/stable-cadencefrom
auto-update-onflow-cadence-v1.0.0-preview.30

Conversation

@turbolent

Copy link
Copy Markdown
Member Author

@sideninja @m-Peter Can you please update internal/evm/gateway.go according to the changes in EVM Gateway?

@ianthpun

Copy link
Copy Markdown
Contributor

@turbolent are you able to update the emulator to .26 here please? I would like those changes in here as well. Thanks!

@codecov-commenter

codecov-commenter commented Jun 2, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 34.40%. Comparing base (113a916) to head (c4234b4).

Files Patch % Lines
internal/evm/gateway.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/stable-cadence    #1631      +/-   ##
==========================================================
- Coverage                   42.69%   34.40%   -8.29%     
==========================================================
  Files                          60       96      +36     
  Lines                        4195     5917    +1722     
==========================================================
+ Hits                         1791     2036     +245     
- Misses                       2169     3604    +1435     
- Partials                      235      277      +42     
Flag Coverage Δ
unittests 34.40% <0.00%> (-8.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m-Peter

m-Peter commented Jun 2, 2024

Copy link
Copy Markdown
Collaborator

@ianthpun I updated the emulator to .26 in c4234b4.

@turbolent The CI is ✅

@turbolent

Copy link
Copy Markdown
Member Author

@m-Peter thank you!

@ianthpun Have the other dependencies which depend on the Emulator, like the language server also been updated?

@turbolent

Copy link
Copy Markdown
Member Author

Given that not all dependencies have been updated yet to Emulator .26 I reverted the bump here, to unblock the urgently needed release of a preview CLI build.

@ianthpun

ianthpun commented Jun 3, 2024

Copy link
Copy Markdown
Contributor

@turbolent everything else has been merged in, the CLI is the last bit!

EDIT: I take it back , we'll need to update language server as well. We'll update the CLI shortly afterwords to unlbock this release

@turbolent turbolent merged commit c016b78 into feature/stable-cadence Jun 3, 2024
@turbolent turbolent deleted the auto-update-onflow-cadence-v1.0.0-preview.30 branch June 3, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants