Skip to content

Fix counter path from init#1648

Merged
chasefleming merged 6 commits into
masterfrom
cf/fix-counter-path
Jun 11, 2024
Merged

Fix counter path from init#1648
chasefleming merged 6 commits into
masterfrom
cf/fix-counter-path

Conversation

@chasefleming

Copy link
Copy Markdown
Member

Closes #1647


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Comment thread internal/super/generate.go Outdated
@codecov-commenter

codecov-commenter commented Jun 10, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.09%. Comparing base (7fb7ec7) to head (f6eaffe).

Files Patch % Lines
internal/super/setup.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1648      +/-   ##
==========================================
+ Coverage   39.08%   39.09%   +0.01%     
==========================================
  Files          52       52              
  Lines        3536     3535       -1     
==========================================
  Hits         1382     1382              
+ Misses       1979     1978       -1     
  Partials      175      175              
Flag Coverage Δ
unittests 39.09% <83.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chasefleming chasefleming merged commit ca4e1b5 into master Jun 11, 2024
@chasefleming chasefleming deleted the cf/fix-counter-path branch June 11, 2024 16:55
@chasefleming chasefleming added Feature A new user feature or a new package API Bug The issue represents a bug, malfunction, regression and removed Feature A new user feature or a new package API labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug The issue represents a bug, malfunction, regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Counter path on init is incorrect

4 participants