Skip to content

Additional path fixes for generator#1650

Merged
chasefleming merged 2 commits into
masterfrom
cf/gen-path-fixes
Jun 11, 2024
Merged

Additional path fixes for generator#1650
chasefleming merged 2 commits into
masterfrom
cf/gen-path-fixes

Conversation

@chasefleming

Copy link
Copy Markdown
Member

Closes #1647


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 39.16%. Comparing base (ca4e1b5) to head (3165ef3).

Files Patch % Lines
internal/super/generate.go 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1650      +/-   ##
==========================================
+ Coverage   39.09%   39.16%   +0.06%     
==========================================
  Files          52       52              
  Lines        3535     3539       +4     
==========================================
+ Hits         1382     1386       +4     
  Misses       1978     1978              
  Partials      175      175              
Flag Coverage Δ
unittests 39.16% <50.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chasefleming chasefleming merged commit ebbf96e into master Jun 11, 2024
@chasefleming chasefleming deleted the cf/gen-path-fixes branch June 11, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Counter path on init is incorrect

3 participants