Skip to content

Set default service account key type to hex#17

Merged
Kay-Zee merged 1 commit into
masterfrom
16-service-key-type
Dec 22, 2020
Merged

Set default service account key type to hex#17
Kay-Zee merged 1 commit into
masterfrom
16-service-key-type

Conversation

@psiemens
Copy link
Copy Markdown
Contributor

Closes #16

Description

This fixes a bug in SetServiceAccountKey that was inserting a cli.Account into the Config struct without specifying a key type, which was causing the JSON marshaller to fail in the flow init command.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@Kay-Zee Kay-Zee merged commit ba4369c into master Dec 22, 2020
@psiemens psiemens deleted the 16-service-key-type branch March 25, 2021 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"flow init" fails with JSON error

2 participants