Skip to content

Re-add flow-basic-scaffold, flow-nft-scaffold project scaffolds (with Cadence v1.0 support)#1729

Merged
jribbink merged 2 commits into
onflow:masterfrom
onflowser:update-scaffolds
Sep 20, 2024
Merged

Re-add flow-basic-scaffold, flow-nft-scaffold project scaffolds (with Cadence v1.0 support)#1729
jribbink merged 2 commits into
onflow:masterfrom
onflowser:update-scaffolds

Conversation

@bartolomej

@bartolomej bartolomej commented Sep 5, 2024

Copy link
Copy Markdown
Contributor

Description

Adds back project scaffolds that were migrated to Cadence v1.0.

Depends on:


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter

codecov-commenter commented Sep 5, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.54%. Comparing base (d49c4cf) to head (83c9eb0).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1729      +/-   ##
==========================================
+ Coverage   29.48%   29.54%   +0.06%     
==========================================
  Files          88       88              
  Lines        5166     5154      -12     
==========================================
  Hits         1523     1523              
+ Misses       3456     3444      -12     
  Partials      187      187              
Flag Coverage Δ
unittests 29.54% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bartolomej bartolomej changed the title Add back updated project scaffolds Re-add flow-basic-scaffold, flow-nft-scaffold project scaffolds (with Cadence v1.0 support) Sep 20, 2024
@bartolomej bartolomej marked this pull request as ready for review September 20, 2024 10:21
@jribbink jribbink merged commit d140694 into onflow:master Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants