Skip to content

Fix CLI hanging with certain commands#1730

Merged
jribbink merged 2 commits into
masterfrom
jribbink/fix-hang
Sep 6, 2024
Merged

Fix CLI hanging with certain commands#1730
jribbink merged 2 commits into
masterfrom
jribbink/fix-hang

Conversation

@jribbink

@jribbink jribbink commented Sep 5, 2024

Copy link
Copy Markdown
Contributor

Closes #1731


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 29.47%. Comparing base (d49c4cf) to head (a4d25d9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/flow/main.go 0.00% 1 Missing ⚠️
internal/command/command.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1730      +/-   ##
==========================================
- Coverage   29.48%   29.47%   -0.01%     
==========================================
  Files          88       88              
  Lines        5166     5167       +1     
==========================================
  Hits         1523     1523              
- Misses       3456     3457       +1     
  Partials      187      187              
Flag Coverage Δ
unittests 29.47% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jribbink jribbink merged commit 5a1d3f8 into master Sep 6, 2024
@jribbink jribbink deleted the jribbink/fix-hang branch September 6, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI Hangs with certain commands

3 participants