Skip to content

Use semver comparison for new version check#1749

Merged
jribbink merged 3 commits into
masterfrom
jribbink/version-check
Sep 17, 2024
Merged

Use semver comparison for new version check#1749
jribbink merged 3 commits into
masterfrom
jribbink/version-check

Conversation

@jribbink

@jribbink jribbink commented Sep 17, 2024

Copy link
Copy Markdown
Contributor

Closes #1747


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink added Bugfix Improvement Technical work without new features, refactoring, improving tests and removed Bugfix labels Sep 17, 2024
@codecov-commenter

codecov-commenter commented Sep 17, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/command/command.go 0.00% 7 Missing ⚠️

📢 Thoughts on this report? Let us know!

@jribbink jribbink merged commit 15cb2ba into master Sep 17, 2024
@jribbink jribbink deleted the jribbink/version-check branch September 17, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Technical work without new features, refactoring, improving tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flow CLI warns of new version that's actually older

4 participants