Skip to content

Update fee event filter to align with Crescendo update#1751

Merged
jribbink merged 2 commits into
masterfrom
jribbink/fee-events
Sep 17, 2024
Merged

Update fee event filter to align with Crescendo update#1751
jribbink merged 2 commits into
masterfrom
jribbink/fee-events

Conversation

@jribbink

@jribbink jribbink commented Sep 17, 2024

Copy link
Copy Markdown
Contributor

Closes #1748


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink added the Improvement Technical work without new features, refactoring, improving tests label Sep 17, 2024
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.54%. Comparing base (9b92775) to head (44c6aef).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1751      +/-   ##
==========================================
+ Coverage   29.50%   29.54%   +0.04%     
==========================================
  Files          88       88              
  Lines        5161     5154       -7     
==========================================
  Hits         1523     1523              
+ Misses       3451     3444       -7     
  Partials      187      187              
Flag Coverage Δ
unittests 29.54% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jribbink jribbink merged commit 2ca6aae into master Sep 17, 2024
@jribbink jribbink deleted the jribbink/fee-events branch September 17, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Technical work without new features, refactoring, improving tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transactions get is not removing all fee events

3 participants