Skip to content

Allow usage of Core Contract names for flow deps add#1758

Merged
jribbink merged 2 commits into
masterfrom
jribbink/core-aliases
Sep 23, 2024
Merged

Allow usage of Core Contract names for flow deps add#1758
jribbink merged 2 commits into
masterfrom
jribbink/core-aliases

Conversation

@jribbink

@jribbink jribbink commented Sep 18, 2024

Copy link
Copy Markdown
Contributor

Closes #1753

Description


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter

codecov-commenter commented Sep 18, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 68.96552% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/dependencymanager/add.go 0.00% 5 Missing ⚠️
internal/dependencymanager/dependencyinstaller.go 83.33% 2 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

Comment thread internal/dependencymanager/add.go
@jribbink jribbink merged commit 10ebb57 into master Sep 23, 2024
@jribbink jribbink deleted the jribbink/core-aliases branch September 23, 2024 19:29
@jribbink jribbink added the Feature A new user feature or a new package API label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature A new user feature or a new package API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add aliases for Core Contracts in Dependency Manager

3 participants