Fix json encoding for transaction result#1768
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1768 +/- ##
=======================================
Coverage 29.68% 29.68%
=======================================
Files 89 89
Lines 5191 5191
=======================================
Hits 1541 1541
Misses 3463 3463
Partials 187 187
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
Thanks for the contribution! Will review today 🫡 |
jribbink
approved these changes
Sep 24, 2024
jribbink
left a comment
Contributor
There was a problem hiding this comment.
Nice, thank you! Must have broken at some point as event encoding changed to CCF :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1715
Description
Fixed the issue where an empty string was returned when using flow transaction get with the -o json option.
For contributor use:
masterbranchFiles changedin the Github PR explorer